From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Roland McGrath <roland@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ananth N Mavinakaynahalli <ananth@in.ibm.com>,
stan_shebs@mentor.com
Subject: Re: [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step
Date: Wed, 08 Aug 2012 15:17:52 +0200 [thread overview]
Message-ID: <50226700.9000606@linutronix.de> (raw)
In-Reply-To: <20120808125709.GA4504@redhat.com>
On 08/08/2012 02:57 PM, Oleg Nesterov wrote:
>> +static int insn_changes_flags(struct arch_uprobe *auprobe)
>> +{
>> + /* popf reads flags from stack */
>> + if (auprobe->insn[0] == 0x9d)
>> + return 1;
>
> Ah, somehow I didn't think about this before.
>
> ->insn[0] doesn't look right, we should skip the prefixes.
Why? I tried 'lock popf' and I got invalid instruction. The same for
'rep popf'.
> Oleg.
>
Sebastian
next prev parent reply other threads:[~2012-08-08 13:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 16:12 uprobe: single step over uprobe & global breakpoints Sebastian Andrzej Siewior
2012-08-07 16:12 ` [PATCH 1/5] uprobes: Use a helper instead of ptrace's single step enable Sebastian Andrzej Siewior
2012-08-07 16:12 ` [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step Sebastian Andrzej Siewior
2012-08-08 12:57 ` Oleg Nesterov
2012-08-08 13:17 ` Sebastian Andrzej Siewior [this message]
2012-08-08 14:53 ` Oleg Nesterov
2012-08-08 15:02 ` Sebastian Andrzej Siewior
2012-08-09 4:43 ` Ananth N Mavinakayanahalli
2012-08-09 17:09 ` [PATCH v2 " Sebastian Andrzej Siewior
2012-08-13 13:24 ` Oleg Nesterov
2012-08-14 8:28 ` Sebastian Andrzej Siewior
2012-08-14 14:27 ` Oleg Nesterov
2012-08-20 10:47 ` [PATCH v3] " Sebastian Andrzej Siewior
2012-08-22 14:03 ` Oleg Nesterov
2012-08-22 14:11 ` Sebastian Andrzej Siewior
2012-08-22 15:59 ` Oleg Nesterov
2012-08-29 17:37 ` Oleg Nesterov
2012-08-30 8:47 ` Ananth N Mavinakayanahalli
2012-08-30 11:18 ` [PATCH] x86/uprobes: don't disable single stepping if it was already on Sebastian Andrzej Siewior
2012-08-30 14:37 ` [PATCH v3] x86/uprobes: implement x86 specific arch_uprobe_*_step Oleg Nesterov
2012-08-30 15:03 ` Ananth N Mavinakayanahalli
2012-08-30 15:11 ` Oleg Nesterov
2012-08-07 16:12 ` [PATCH 3/5] uprobes: remove check for uprobe variable in handle_swbp() Sebastian Andrzej Siewior
2012-08-08 9:10 ` Suzuki K. Poulose
2012-08-08 9:35 ` Sebastian Andrzej Siewior
2012-08-10 5:23 ` Suzuki K. Poulose
2012-08-08 12:58 ` Oleg Nesterov
2012-08-07 16:12 ` [PATCH 4/5] uprobes: probe definiton can only start with 'p' and '-' Sebastian Andrzej Siewior
2012-08-07 16:12 ` [RFC 5/5] uprobes: add global breakpoints Sebastian Andrzej Siewior
2012-08-08 13:14 ` Oleg Nesterov
2012-08-09 17:18 ` Sebastian Andrzej Siewior
2012-08-13 13:16 ` Oleg Nesterov
2012-08-14 11:43 ` Sebastian Andrzej Siewior
2012-08-13 11:34 ` Peter Zijlstra
2012-08-20 15:26 ` Sebastian Andrzej Siewior
2012-08-21 19:42 ` [RFC 5/5 v2] " Sebastian Andrzej Siewior
2012-08-22 13:48 ` Oleg Nesterov
2012-08-27 18:56 ` Sebastian Andrzej Siewior
2012-08-29 15:49 ` Oleg Nesterov
2012-08-30 20:42 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50226700.9000606@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=stan_shebs@mentor.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.