From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Wed, 08 Aug 2012 18:25:19 +0200 Message-ID: <502292EF.3010202@suse.de> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F27F436.9020801@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , KVM devel mailing list , Developers qemu-devel , Dmitry Solodkiy , Jason Baron , Alexander Graf To: i.mitsyanko@samsung.com, quintela@redhat.com Return-path: Received: from cantor2.suse.de ([195.135.220.15]:39804 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab2HHQZZ (ORCPT ); Wed, 8 Aug 2012 12:25:25 -0400 In-Reply-To: <4F27F436.9020801@samsung.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 31.01.2012 15:01, schrieb Mitsyanko Igor: > On 01/31/2012 05:15 PM, Andreas F=C3=A4rber wrote: >> Am 31.01.2012 00:53, schrieb Anthony Liguori: >>> On 01/30/2012 05:41 PM, Andreas F=C3=A4rber wrote: >>>> Am 30.01.2012 19:55, schrieb Juan Quintela: >>>>> Please send in any agenda items you are interested in covering. >> >>>> VMState: >>>> Anthony specifically said that VMState were not affected by QOM an= d >>>> that >>>> patches should not be deferred until the merge. Yet there's no rev= iew >>>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC. >>> >>> Do you have pointers (to pending VMState patches)? >> >> http://patchwork.ozlabs.org/patch/137732/ (PATCH v4) >> >> It's basically about how to deal with variable-sized arrays. (Alex >> mentioned it on one call around November.) I found ways to deal with >> subsets of arrays embedded within the struct and variable-sized list= of >> pointers to structs but no solution for a malloc()'ed array of struc= ts. >> Maybe I'm just too stupid to see. Anyway, no one commented since Xma= s. >> >> Igor posted (and refined for v2) a patch with a callback-based appro= ach >> that I find promising. From my view, unofficially Juan is the VMStat= e >> guy, he's been cc'ed. Are we lacking an official maintainer that car= es? >> Or is Juan the official, undocumented maintainer but simply busy? >> >> SUSE's interest is making AHCI migratable, and my VMState workaround= for >> that is simply ugly: >> >> http://patchwork.ozlabs.org/patch/133066/ (RFC) >> >=20 > If I'm not mistaken, if you change AHCIState's ".ports" type to uint3= 2_t > you can use existing VMSTATE_BUFFER_MULTIPLY macro like this: >=20 > VMSTATE_BUFFER_MULTIPLY(dev, AHCIState, 0, NULL, 0, ports, > sizeof(AHCIDevice)) Igor, I finally got around to rebasing and trying this: Am I seeing correctly that this tries to serialize the whole of AHCIDevice as an opaque buffer? The difficulty here was that we were looking for a way t= o serialize a variable number of structured elements with their own &vmstate_ahci_device specifying what fields to serialize. Juan, how should we proceed there? Do as Igor suggested? Some VMSTATE_ macro I'm overlooking? Or do we need some new macro for this use case? Regards, Andreas > VMSTATE_BUFFER_MULTIPLY currently lacks VMS_POINTER flag and therefor= e > doesn't make any use of _start field (you don't need it anyway) >=20 > Nevertheless, VMSTATE_BUFFER_MULTIPLY is just a partial solution to a > bigger set of possible problems. SD card's vmstate implementation > requires shift operation, SDHC gets size from switch {} statement, > something else later may require division or addition e.t.c., > get_bufsize callback will cover all possible cases. --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz94a-0001SO-F7 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 12:25:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz94Y-00004v-OY for qemu-devel@nongnu.org; Wed, 08 Aug 2012 12:25:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39802 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz94Y-0008W7-Eg for qemu-devel@nongnu.org; Wed, 08 Aug 2012 12:25:26 -0400 Message-ID: <502292EF.3010202@suse.de> Date: Wed, 08 Aug 2012 18:25:19 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F27F436.9020801@samsung.com> In-Reply-To: <4F27F436.9020801@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: i.mitsyanko@samsung.com, quintela@redhat.com Cc: KVM devel mailing list , Jason Baron , Alexander Graf , Developers qemu-devel , Dmitry Solodkiy , Anthony Liguori Am 31.01.2012 15:01, schrieb Mitsyanko Igor: > On 01/31/2012 05:15 PM, Andreas F=C3=A4rber wrote: >> Am 31.01.2012 00:53, schrieb Anthony Liguori: >>> On 01/30/2012 05:41 PM, Andreas F=C3=A4rber wrote: >>>> Am 30.01.2012 19:55, schrieb Juan Quintela: >>>>> Please send in any agenda items you are interested in covering. >> >>>> VMState: >>>> Anthony specifically said that VMState were not affected by QOM and >>>> that >>>> patches should not be deferred until the merge. Yet there's no revie= w >>>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC. >>> >>> Do you have pointers (to pending VMState patches)? >> >> http://patchwork.ozlabs.org/patch/137732/ (PATCH v4) >> >> It's basically about how to deal with variable-sized arrays. (Alex >> mentioned it on one call around November.) I found ways to deal with >> subsets of arrays embedded within the struct and variable-sized list o= f >> pointers to structs but no solution for a malloc()'ed array of structs= . >> Maybe I'm just too stupid to see. Anyway, no one commented since Xmas. >> >> Igor posted (and refined for v2) a patch with a callback-based approac= h >> that I find promising. From my view, unofficially Juan is the VMState >> guy, he's been cc'ed. Are we lacking an official maintainer that cares= ? >> Or is Juan the official, undocumented maintainer but simply busy? >> >> SUSE's interest is making AHCI migratable, and my VMState workaround f= or >> that is simply ugly: >> >> http://patchwork.ozlabs.org/patch/133066/ (RFC) >> >=20 > If I'm not mistaken, if you change AHCIState's ".ports" type to uint32_= t > you can use existing VMSTATE_BUFFER_MULTIPLY macro like this: >=20 > VMSTATE_BUFFER_MULTIPLY(dev, AHCIState, 0, NULL, 0, ports, > sizeof(AHCIDevice)) Igor, I finally got around to rebasing and trying this: Am I seeing correctly that this tries to serialize the whole of AHCIDevice as an opaque buffer? The difficulty here was that we were looking for a way to serialize a variable number of structured elements with their own &vmstate_ahci_device specifying what fields to serialize. Juan, how should we proceed there? Do as Igor suggested? Some VMSTATE_ macro I'm overlooking? Or do we need some new macro for this use case? Regards, Andreas > VMSTATE_BUFFER_MULTIPLY currently lacks VMS_POINTER flag and therefore > doesn't make any use of _start field (you don't need it anyway) >=20 > Nevertheless, VMSTATE_BUFFER_MULTIPLY is just a partial solution to a > bigger set of possible problems. SD card's vmstate implementation > requires shift operation, SDHC gets size from switch {} statement, > something else later may require division or addition e.t.c., > get_bufsize callback will cover all possible cases. --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg