From: Milan Broz <mbroz@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "device-mapper development" <dm-devel@redhat.com>,
"Alasdair Kergon" <agk@redhat.com>,
"msb@google.com" <msb@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Will Drewry™" <w@google.com>,
wmiaw@netflix.com
Subject: Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)
Date: Wed, 08 Aug 2012 22:31:21 +0200 [thread overview]
Message-ID: <5022CC99.30103@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1208081437550.16469@file.rdu.redhat.com>
On 08/08/2012 08:46 PM, Mikulas Patocka wrote:
> The problem with the patch is that it changes interface to the userspace
> tool. The userspace tool veritysetup already exists in recent cryptsetup
> package, so we can't change the interface - you should change the patch so
> that the starting data block is the last argument and the argument is
> optional - so that it is compatible with the existing userspace too.
yes. Please never change interface without at least increasing target version.
I have to add userspace support as well to veritysetup and we need a way
how to detect that option is supported by running kernel.
Milan
next prev parent reply other threads:[~2012-08-08 20:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 18:23 [PATCH] dm: verity support data device offset (Linux 3.4.7) Wesley Miaw
2012-08-08 18:46 ` [dm-devel] " Mikulas Patocka
2012-08-08 20:31 ` Milan Broz [this message]
2012-08-08 20:46 ` Wesley Miaw
2012-08-08 20:56 ` Milan Broz
2012-08-08 21:53 ` Wesley Miaw
2012-08-09 0:40 ` [dm-devel] [PATCH v2 2/2] " Wesley Miaw
2012-08-09 1:53 ` Alasdair G Kergon
2012-08-09 6:35 ` Milan Broz
2012-08-09 17:09 ` Wesley Miaw
2012-08-09 0:40 ` [dm-devel] [PATCH v2 1/2] " Wesley Miaw
2012-08-09 2:04 ` Alasdair G Kergon
2012-08-10 1:00 ` Wesley Miaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5022CC99.30103@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msb@google.com \
--cc=w@google.com \
--cc=wmiaw@netflix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.