From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches Subject: Re: [PATCH] mmc: atmel-mci: not busy flag has also to be used for read operations Date: Thu, 9 Aug 2012 08:29:15 +0200 Message-ID: <502358BB.8010801@atmel.com> References: <1343122924-7799-1-git-send-email-ludovic.desroches@atmel.com> <87lihqxev6.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <87lihqxev6.fsf@octavius.laptop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chris Ball Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, ludovic.desroches@atmel.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org Le 08/08/2012 05:05 AM, Chris Ball a =E9crit : > Hi, > > On Tue, Jul 24 2012, ludovic.desroches@atmel.com wrote: >> From: Ludovic Desroches >> >> Even if the datasheet says that the not busy flag has to be used only for >> write operations, it's false excepted for version lesser than v2xx. >> Not waiting the not busy flag for read operations can cause the controll= er to >> hang-up during the initialization of some SD cards. >> >> Signed-off-by: Ludovic Desroches >> Cc: stable@vger.kernel.org >> >> >> Hello, >> >> This is a fix for 3.5 and later. >> >> Due to the big changes into atmel-mci driver to support all atmel mci ve= rsions, >> a bug was introduced. >> With some SD cards (mainly micro) when using DMA, the controller hangs-u= p after >> the first CMD6 command because the next command is sent too early. >> >> Regards >> >> Ludovic >> >> >> --- >> drivers/mmc/host/atmel-mci.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) > > Thanks. I've applied this for mmc-next now, but please put your patch > commentary *underneath* the "---" lines, so that it doesn't end up in > the git history itself. I've rewritten the commit message to be: Sorry for this error. Thanks Ludovic > > > From: Ludovic Desroches > > Even if the datasheet says that the not busy flag has to be used only > for write operations, it's false except for version lesser than v2xx. > > Not waiting on the not busy flag for read operations can cause the > controller to hang-up during the initialization of some SD cards > with DMA after the first CMD6 -- the next command is sent too early. > > Signed-off-by: Ludovic Desroches > Cc: stable [3.5, 3.6] > Signed-off-by: Chris Ball > --- > > > drivers/mmc/host/atmel-mci.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (ludovic.desroches) Date: Thu, 9 Aug 2012 08:29:15 +0200 Subject: [PATCH] mmc: atmel-mci: not busy flag has also to be used for read operations In-Reply-To: <87lihqxev6.fsf@octavius.laptop.org> References: <1343122924-7799-1-git-send-email-ludovic.desroches@atmel.com> <87lihqxev6.fsf@octavius.laptop.org> Message-ID: <502358BB.8010801@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 08/08/2012 05:05 AM, Chris Ball a ?crit : > Hi, > > On Tue, Jul 24 2012, ludovic.desroches at atmel.com wrote: >> From: Ludovic Desroches >> >> Even if the datasheet says that the not busy flag has to be used only for >> write operations, it's false excepted for version lesser than v2xx. >> Not waiting the not busy flag for read operations can cause the controller to >> hang-up during the initialization of some SD cards. >> >> Signed-off-by: Ludovic Desroches >> Cc: stable at vger.kernel.org >> >> >> Hello, >> >> This is a fix for 3.5 and later. >> >> Due to the big changes into atmel-mci driver to support all atmel mci versions, >> a bug was introduced. >> With some SD cards (mainly micro) when using DMA, the controller hangs-up after >> the first CMD6 command because the next command is sent too early. >> >> Regards >> >> Ludovic >> >> >> --- >> drivers/mmc/host/atmel-mci.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) > > Thanks. I've applied this for mmc-next now, but please put your patch > commentary *underneath* the "---" lines, so that it doesn't end up in > the git history itself. I've rewritten the commit message to be: Sorry for this error. Thanks Ludovic > > > From: Ludovic Desroches > > Even if the datasheet says that the not busy flag has to be used only > for write operations, it's false except for version lesser than v2xx. > > Not waiting on the not busy flag for read operations can cause the > controller to hang-up during the initialization of some SD cards > with DMA after the first CMD6 -- the next command is sent too early. > > Signed-off-by: Ludovic Desroches > Cc: stable [3.5, 3.6] > Signed-off-by: Chris Ball > --- > > > drivers/mmc/host/atmel-mci.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >