From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V Date: Thu, 09 Aug 2012 10:57:04 +0200 Message-ID: <50237B60.2080002@canonical.com> References: <1344501327-7136-1-git-send-email-david.henningsson@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id 423D22661DD for ; Thu, 9 Aug 2012 10:27:15 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, 1034779@bugs.launchpad.net List-Id: alsa-devel@alsa-project.org On 08/09/2012 10:54 AM, Takashi Iwai wrote: > At Thu, 9 Aug 2012 10:35:27 +0200, > David Henningsson wrote: >> >> To turn off pin control for the pin was tested, and helped against >> this issue. >> >> BugLink: https://bugs.launchpad.net/bugs/1034779 >> Tested-by: Chih-Hsyuan Ho >> Signed-off-by: David Henningsson >> --- >> sound/pci/hda/patch_via.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> Alsa-info at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1034779/+attachment/3254105/+files/asus-x55a-alsa-info.log >> >> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c >> index 80d90cb..c9484fe 100644 >> --- a/sound/pci/hda/patch_via.c >> +++ b/sound/pci/hda/patch_via.c >> @@ -1752,6 +1752,14 @@ static int via_suspend(struct hda_codec *codec) >> { >> struct via_spec *spec = codec->spec; >> vt1708_stop_hp_work(spec); >> + >> + if (spec->codec_type == VT1802) { >> + /* Fix pop noise on headphones */ >> + int i; >> + for (i = 0; i < spec->autocfg.hp_outs; i++) >> + snd_hda_set_pin_ctl(codec, spec->autocfg.hp_pins[0], 0); > > Shouldn't this be spec->autocfg.hp_pins[i]? D'oh. Thanks for the review, sent new patch. Of course the actual machine only had one HP out, so the bug was not discovered by testing. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic