All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Sergio Aguirre <saaguirre@ti.com>,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH 2/3] mfd: twl6040: Add twl6040-gpio child
Date: Thu, 09 Aug 2012 15:10:22 +0300	[thread overview]
Message-ID: <5023A8AE.5050300@ti.com> (raw)
In-Reply-To: <20120809115531.GB8474@sirena.org.uk>

On 08/09/2012 02:55 PM, Mark Brown wrote:
> On Mon, Jul 30, 2012 at 05:13:17PM +0300, Peter Ujfalusi wrote:
> 
>> If the board needs the gpo driver, but in the driver(s) I need to check for
>> the existence of the "ti,twl6040-gpo" node and check if the status is "okay".
>> I think it is easier to just get the value of "ti,use-gpo", if it exist and it
>> is 1 I enable the GPIO driver otherwise I don't.
> 
> Will having the GPIO driver actually cause any problems if it's not in
> use?  It's not like things like RTC which are directly visible to
> userspace and so can create problems if they're non-functional, unless
> it does something like grab resources that might be needed by another
> subfunction driver there's not really a substantial cost in just
> instantiating it (people who are really space pressured probably won't
> build the driver in in the first place).

Fair enough, I'll make the change for the v2.

-- 
Péter

  reply	other threads:[~2012-08-09 12:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  9:20 [PATCH 0/3] MFD/GPIO: Add twl6040 GPO driver Peter Ujfalusi
2012-07-18  9:20 ` [PATCH 1/3] mfd: twl6040: Fix GPO mask Peter Ujfalusi
2012-07-27 22:45   ` Linus Walleij
2012-07-30 14:17     ` Peter Ujfalusi
2012-07-18  9:20 ` [PATCH 2/3] mfd: twl6040: Add twl6040-gpio child Peter Ujfalusi
2012-07-27 22:50   ` Linus Walleij
2012-07-30 14:13     ` Peter Ujfalusi
2012-08-09 11:55       ` Mark Brown
2012-08-09 12:10         ` Peter Ujfalusi [this message]
2012-07-18  9:20 ` [PATCH 3/3] gpio: Add basic support for TWL6040 GPOs Peter Ujfalusi
2012-07-27 22:55   ` Linus Walleij
2012-07-27 22:43 ` [PATCH 0/3] MFD/GPIO: Add twl6040 GPO driver Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5023A8AE.5050300@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saaguirre@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.