From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzUSk-0002qg-U7 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:15:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzUSf-0001kM-0d for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:15:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35898 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzUSe-0001il-M4 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:15:44 -0400 Message-ID: <5023D419.2060205@suse.de> Date: Thu, 09 Aug 2012 17:15:37 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1340632507-29692-1-git-send-email-imammedo@redhat.com> <1340632507-29692-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1340632507-29692-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] target-i386: drop usage of prev_debug_excp_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, sw@weilnetz.de, mtosatti@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, jcmvbkbc@gmail.com, avi@redhat.com, jan.kiszka@siemens.com, mdroth@linux.vnet.ibm.com, rth@twiddle.net Am 25.06.2012 15:55, schrieb Igor Mammedov: > Chains of exception handlers are currently unused feature, drop it > for now so as not to expose prev_debug_excp_handler at global > scope when moving tcg initialization into target-i386/cpu.c >=20 > Later we probably could re-invent better interface for this. >=20 > Signed-off-by: Igor Mammedov FWIW, Reviewed-by: Andreas F=E4rber /-F > --- > target-i386/helper.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 2cc8097..b9384f6 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -941,8 +941,6 @@ int check_hw_breakpoints(CPUX86State *env, int forc= e_dr6_update) > return hit_enabled; > } > =20 > -static CPUDebugExcpHandler *prev_debug_excp_handler; > - > static void breakpoint_handler(CPUX86State *env) > { > CPUBreakpoint *bp; > @@ -965,8 +963,6 @@ static void breakpoint_handler(CPUX86State *env) > break; > } > } > - if (prev_debug_excp_handler) > - prev_debug_excp_handler(env); > } > =20 > typedef struct MCEInjectionParams { > @@ -1166,8 +1162,7 @@ X86CPU *cpu_x86_init(const char *cpu_model) > inited =3D 1; > optimize_flags_init(); > #ifndef CONFIG_USER_ONLY > - prev_debug_excp_handler =3D > - cpu_set_debug_excp_handler(breakpoint_handler); > + cpu_set_debug_excp_handler(breakpoint_handler); > #endif > } > if (cpu_x86_register(cpu, cpu_model) < 0) { >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg