From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzWLH-0003OX-2x for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzWLG-0001Sg-8T for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:16:15 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:49652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzWLG-0001EP-0i for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:16:14 -0400 Message-ID: <5023F054.7090500@msgid.tls.msk.ru> Date: Thu, 09 Aug 2012 21:16:04 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1344519511-18147-1-git-send-email-pbonzini@redhat.com> <1344519511-18147-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1344519511-18147-6-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] scsi-disk: more assertions and resets for aiocb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 09.08.2012 17:38, Paolo Bonzini wrote: > Leaving the aiocb to a non-NULL value leads to an assertion failure when > rerror/werror are set to stop or enospc, and the operation is retried. > scsi-disk checks that the aiocb member is NULL before filling it. > > This patch correctly resets the aiocb to NULL values everywhere, > and adds the dual assertion that the aiocb was non-NULL before > calling bdrv_acct_done. Stable matherial? Thanks, /mjt