All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org,
	kwilczynski@kernel.org, bhelgaas@google.com,
	linux-pci@vger.kernel.org, robh@kernel.org,
	thierry.reding@kernel.org, jonathanh@nvidia.com,
	vidyas@nvidia.com, cassel@kernel.org,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 1/2] PCI: tegra194: Use FIELD_*() for register fields
Date: Tue, 17 Nov 2026 19:03:01 +0530	[thread overview]
Message-ID: <5023b5cd-e454-4789-8290-92be81e14ec5@nvidia.com> (raw)
In-Reply-To: <20261116170109.GA71319@bhelgaas>



On 16/11/26 10:31 pm, Bjorn Helgaas wrote:
> On Mon, Nov 09, 2026 at 11:19:06AM -0600, Bjorn Helgaas wrote:
>> On Mon, Nov 02, 2026 at 02:52:37PM +0530, Manikanta Maddireddy wrote:
>>> Several Tegra194 APPL and DesignWare register fields are programmed
>>> with open-coded shifts, which makes the register programming more
>>> verbose than necessary.
>>>
>>> Use FIELD_PREP(), FIELD_MODIFY() and FIELD_GET() at the Tegra call
>>> sites where values are shifted into fields. The LTSSM state constants
>>> are converted from pre-shifted register values to unshifted field
>>> values for FIELD_GET().
>>>
>>> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
>>> Link: https://lore.kernel.org/r/20260515070753.3852840-2-mmaddireddy@nvidia.com
>>
>> Thanks for this patch; it's great to get rid of the redundant *_SHIFT
>> definitions.
>>
>> But I'm confused about why this Link: is here.  It points to "[PATCH
>> v3 1/2] PCI: tegra194: Use aspm-l1-entry-delay-ns DT property for L1
>> entrance latency", which looks like a functional change.
>>
>> This patch should be zero functional changes; it should be purely
>> mechanical changes from explicit shifts to using FIELD_MODIFY() etc.
>>
>> This patch doesn't mention aspm-l1-entry-delay-ns, so it doesn't
>> *look* like this includes the [PATCH v3 1/2] content.
> 
> https://lore.kernel.org/r/20260515070753.3852840-2-mmaddireddy@nvidia.com
> is a change that was already merged as 87f493041e20 ("PCI: tegra194:
> Use aspm-l1-entry-delay-ns DT property for L1 entrance latency").
> 
> *This* patch only reworks it to use FIELD_MODIFY().  I dropped that
> Link: tag to avoid confusion.  And also put both PORT_AFAC_L0S_ELM and
> PORT_AFAC_L1_ELM on one line since they fit easily.

Thank you, Bjorn, for removing the misleading Link tag and simplifying 
the formatting.

I intended to reference your suggestion to replace the SHIFT definitions 
with FIELD() helpers, but linked to the original patch instead of your 
review comment at 
https://lore.kernel.org/all/20260520193024.GA84903@bhelgaas/

-- 
nvpublic


  reply	other threads:[~2026-11-17 13:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  9:22 [PATCH v3 0/2] PCI: dwc: Clean up RAS-DES and register field handling Manikanta Maddireddy
2026-11-02  9:22 ` [PATCH v3 1/2] PCI: tegra194: Use FIELD_*() for register fields Manikanta Maddireddy
2026-11-02  9:27   ` sashiko-bot
2026-11-09 17:19   ` Bjorn Helgaas
2026-11-16 17:01     ` Bjorn Helgaas
2026-11-17 13:33       ` Manikanta Maddireddy [this message]
2026-11-17 22:15   ` David Laight
2026-11-02  9:22 ` [PATCH v3 2/2] PCI: dwc: Consolidate RAS-DES event counter fields Manikanta Maddireddy
2026-11-02  9:27   ` sashiko-bot
2026-11-07 17:05 ` [PATCH v3 0/2] PCI: dwc: Clean up RAS-DES and register field handling Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5023b5cd-e454-4789-8290-92be81e14ec5@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.