From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzsAz-000278-0m for qemu-devel@nongnu.org; Fri, 10 Aug 2012 12:35:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzsAx-0002hj-VH for qemu-devel@nongnu.org; Fri, 10 Aug 2012 12:35:04 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:9984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzsAx-0002eE-PL for qemu-devel@nongnu.org; Fri, 10 Aug 2012 12:35:03 -0400 Received: from eusync1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8J00E28SRFMQ10@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 10 Aug 2012 17:35:39 +0100 (BST) Received: from [106.109.9.232] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M8J006F0SQC4L10@eusync1.samsung.com> for qemu-devel@nongnu.org; Fri, 10 Aug 2012 17:35:01 +0100 (BST) Message-id: <50253834.10508@samsung.com> Date: Fri, 10 Aug 2012 20:35:00 +0400 From: Igor Mitsyanko MIME-version: 1.0 References: <1344513263-22971-1-git-send-email-peter.maydell@linaro.org> <50253537.1070003@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Juan Quintela , qemu-devel@nongnu.org, patches@linaro.org On 08/10/2012 08:30 PM, Peter Maydell wrote: > On 10 August 2012 17:22, Igor Mitsyanko wrote: >> On 08/09/2012 03:54 PM, Peter Maydell wrote: >>> --- a/vmstate.h >>> +++ b/vmstate.h >>> @@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64; >>> extern const VMStateInfo vmstate_info_timer; >>> extern const VMStateInfo vmstate_info_buffer; >>> extern const VMStateInfo vmstate_info_unused_buffer; >>> +extern const VMStateInfo vmstate_info_bitmap; >>> #define type_check_array(t1,t2,n) ((t1(*)[n])0 - (t2*)0) >>> #define type_check_pointer(t1,t2) ((t1**)0 - (t2*)0) >>> @@ -411,6 +412,18 @@ extern const VMStateInfo vmstate_info_unused_buffer; >>> .flags = VMS_BUFFER, \ >>> } >>> +/* _field_size should be a uint32_t field in the _state struct giving >>> the >> >> "..should be an int32_t.." > Er, yes. This patch should probably go in as part of your series > to add save/load to sd.c -- could you just fix this when you resend > the patch as part of that, please? > > thanks > -- PMM > sure