From: Valdis.Kletnieks@vt.edu
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, jmorris@namei.org,
eric.dumazet@gmail.com, tgraf@infradead.org,
eugeneteo@kernel.org, kees.cook@canonical.com, mingo@elte.hu,
davem@davemloft.net, a.p.zijlstra@chello.nl,
akpm@linux-foundation.org
Subject: Re: [PATCH v3] kptr_restrict for hiding kernel pointers
Date: Mon, 20 Dec 2010 17:26:31 -0500 [thread overview]
Message-ID: <50259.1292883991@localhost> (raw)
In-Reply-To: Your message of "Sat, 18 Dec 2010 12:20:34 EST." <1292692835.10804.67.camel@dan>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Sat, 18 Dec 2010 12:20:34 EST, Dan Rosenberg said:
> @@ -1035,6 +1038,26 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
> return buf + vsnprintf(buf, end - buf,
> ((struct va_format *)ptr)->fmt,
> *(((struct va_format *)ptr)->va));
> + case 'K':
> + /*
> + * %pK cannot be used in IRQ context because it tests
> + * CAP_SYSLOG.
> + */
> + if (in_irq() || in_serving_softirq() || in_nmi())
> + WARN_ONCE(1, "%%pK used in interrupt context.\n");
Should this then continue on and test CAP_SYSLOG anyhow, or should it
return a "" or or "<invalid>" or something?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-12-20 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 17:20 [PATCH v3] kptr_restrict for hiding kernel pointers Dan Rosenberg
2010-12-18 18:27 ` Kees Cook
2010-12-18 21:07 ` Eric Paris
2010-12-18 21:10 ` Eric Paris
2010-12-20 22:26 ` Valdis.Kletnieks [this message]
2010-12-20 23:01 ` Dan Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50259.1292883991@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=eric.dumazet@gmail.com \
--cc=eugeneteo@kernel.org \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.