From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Pilcher Subject: Re: [PATCH] drm: EDID quirk improvements Date: Sat, 11 Aug 2012 10:38:15 -0500 Message-ID: <50267C67.6080007@gmail.com> References: <1344572591-14480-2-git-send-email-arequipeno@gmail.com> <1344624288-2672-1-git-send-email-arequipeno@gmail.com> <1344624288-2672-2-git-send-email-arequipeno@gmail.com> <1344673899.5674.11.camel@mattotaupa> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 04C909F754 for ; Sat, 11 Aug 2012 08:38:16 -0700 (PDT) Received: by obbta17 with SMTP id ta17so4029950obb.36 for ; Sat, 11 Aug 2012 08:38:16 -0700 (PDT) In-Reply-To: <1344673899.5674.11.camel@mattotaupa> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paul Menzel Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 08/11/2012 03:31 AM, Paul Menzel wrote: > As a side note, could you also mention the patch iteration in the tag, > that means [PATCH vN] so that I know what is the latest version. That > would be great. Can you (or anyone else reading this) point me to how to do this with git send-email? > I would submit adding the new quirk flags and the LG quirk as separate > patches. If it is not too much work, it would be great if you could > split them up. Does git provide any facility to make this easier? As far as I can tell, the process is to start over with a newly cloned repository, apply the current patch, manually back out the changes that I want to separate, commit, manually redo the separate changes, and commit again. Is that correct? > You even added this one from the following commit. > > commit bc42aabc6a01b92b0f961d65671564e0e1cd7592 > Author: Adam Jackson > Date: Wed May 23 16:26:54 2012 -0400 > > drm/edid/quirks: ViewSonic VA2026w > > I am going to need that quirk. Great! It's in Linus's tree. >> +DEFINE_MUTEX(edid_quirk_list_mutex); >> + >> +/** >> + * drm_edid_mfg_format - format an "encoded" EDID manufacturer ID for printing >> + * @mfg_id: the encoded manufacturer ID >> + * @buf: destination buffer for the formated manufacturer ID (minimum 7 bytes) > > format*t*ed > > http://www.merriam-webster.com/dictionary/formatted Thanks for catching that. I keep finding little typos like that; very annoying. >> + >> + return count; >> +} > > Add an empty line here before the next comment? > >> /*** DDC fetch and block validation ***/ I'm pretty sure I can manage that. ;-) >> +MODULE_PARM_DESC(edid_quirks, "See Documentation/EDID/edid_quirks.txt"); > > Not all users have access to the Linux source tree, so maybe a small > overview is still needed? Or even an URL? I can't think of a way to provide anything useful within the scope of a parameter description. Any suggestions? A URL would be great, but what would it be? (I don't have a personal web site, and that doesn't seem really appropriate anyway.) > Thanks again for that great patch. With the comments addressed above you > can add my acknowledgment. > > Acked-by: Paul Menzel Thank you for your feedback. Are you saying that I should add the acked-by? If so, how? (You can probably tell that I'm really struggling with git.) > I am going to try to test that patch too for a Philips and LG TV [2]. I hope it helps. -- ======================================================================== Ian Pilcher arequipeno@gmail.com "If you're going to shift my paradigm ... at least buy me dinner first." ========================================================================