All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Rankin <rankincj@googlemail.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH] Fix hw_i2c option for RV280 and RV350.
Date: Sat, 11 Aug 2012 23:19:00 +0100	[thread overview]
Message-ID: <5026DA54.5020302@googlemail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

Hi,

I've been carrying this fix privately for far too long; without it, I 
cannot enable the hardware I2C for either of my Radeons RV280 or RV350. 
It does not fix the I2C for my rv100, which remains broken.

The nature of the failure is that the display fails completely:

[   35.067825] [drm:drm_edid_block_valid] *ERROR* EDID checksum is 
invalid, remainder is 230
[   35.076023] Raw EDID:
[   35.078315]          00 ff ff ff ff ff ff 00 ff ff ff ff ff ff ff ff
[   35.084067]          ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[   35.089820]          ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
[   35.095574]          ff ff ff ff ff ff ff ff ff 00 00 ff ff ff ff ff
[   35.101328]          ff ff 1e 1e ff ff ff ff ff ff ff 6d 6d ff ff ff
[   35.107080]          ff ff ff ff 3e 3e ff ff ff ff ff ff ff 4e 4e ff
[   35.112833]          ff ff ff ff ff ff 9a 9a ff ff ff ff ff ff ff f7
[   35.118587]          f7 ff ff ff ff ff ff ff ff ff ff 02 02 ff ff ff
[   35.167737] [drm:drm_edid_block_valid] *ERROR* EDID checksum is 
invalid, remainder is 142

Signed-off-by: Chris Rankin <rankincj@googlemail.com>

Cheers,
Chris

[-- Attachment #2: RADEON_I2C.diff --]
[-- Type: text/x-patch, Size: 398 bytes --]

--- linux-3.5/drivers/gpu/drm/radeon/radeon_i2c.c.orig	2012-06-07 12:41:09.000000000 +0100
+++ linux-3.5/drivers/gpu/drm/radeon/radeon_i2c.c	2012-08-11 23:00:00.000000000 +0100
@@ -245,7 +245,7 @@
 	case CHIP_R300:
 	case CHIP_R350:
 	case CHIP_RV350:
-		i2c_clock = 60;
+		i2c_clock = 100;
 		nm = (sclk * 10) / (i2c_clock * 4);
 		for (loop = 1; loop < 255; loop++) {
 			if ((nm / loop) < loop)

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2012-08-11 22:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5026DA54.5020302@googlemail.com \
    --to=rankincj@googlemail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.