All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm: omap:  Fix switching back to nandecc sw.
Date: Sun, 12 Aug 2012 11:12:37 +0300	[thread overview]
Message-ID: <50276575.3060108@compulab.co.il> (raw)
In-Reply-To: <502569C0.7050804@myspectrum.nl>

Hi Jeroen,

Thanks for the patch!

On 08/10/12 23:06, Jeroen Hofstee wrote:
> Switching back to nandecc sw fails to write correctly. A fix for this is
> already mentioned in the thread below, lets fix it.
> 
> mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

I would expect to have an actual explanation in the commit message
instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...

> 
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>

After the commit message is fixed,

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
>  drivers/mtd/nand/omap_gpmc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> index ca868ef..71aec1a 100644
> --- a/drivers/mtd/nand/omap_gpmc.c
> +++ b/drivers/mtd/nand/omap_gpmc.c
> @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
>          omap_hwecc_init(nand);
>          printf("HW ECC selected\n");
>      } else {
> +        nand->ecc.size = 0;
>          nand->ecc.mode = NAND_ECC_SOFT;
>          /* Use mtd default settings */
>          nand->ecc.layout = NULL;

-- 
Regards,
Igor.

  reply	other threads:[~2012-08-12  8:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 20:06 [U-Boot] arm: omap: Fix switching back to nandecc sw Jeroen Hofstee
2012-08-12  8:12 ` Igor Grinberg [this message]
2012-08-12 12:11   ` Nikita Kiryanov
2012-08-14 20:36 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
2012-08-14 20:39   ` Jeroen Hofstee
2012-08-24 23:39   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50276575.3060108@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.