From: Jonathan Liu <net147@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nodejs: new package
Date: Sun, 12 Aug 2012 18:51:04 +1000 [thread overview]
Message-ID: <50276E78.3030009@gmail.com> (raw)
In-Reply-To: <20120812090610.6cf8fd4d@skate>
Hi Thomas,
On 12/08/2012 5:06 PM, Thomas Petazzoni wrote:
> It would be better if Node.js could use the OpenSSL version that is in
> Buildroot rather than its own internal one. It avoids having two copies
> of OpenSSL on the target system.
>
> And yes, if the SSL support can be enabled/disabled easily, it would be
> great: OpenSSL is a fairly heavy dependency.
Done.
>
>>>> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
>>>> new file mode 100644
>>>> index 0000000..8a0fa91
>>>> --- /dev/null
>>>> +++ b/package/nodejs/nodejs.mk
>>>> @@ -0,0 +1,54 @@
>>>> +#############################################################
>>>> +#
>>>> +# nodejs
>>>> +#
>>>> +#############################################################
>>>> +NODEJS_VERSION = 0.8.6
>>>> +NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
>>>> +NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
>>>> +NODEJS_INSTALL_STAGING = YES
>>> Does NodeJS contains libraries required by other packages?
>> The headers and node-waf binary are needed to build 3rd party native
>> modules. I figured it may be useful if someone wants to create buildroot
>> packages for node.js modules in the future.
> Can you add a comment with a similar explanation just before this line.
> For libraries, the reason to have _INSTALL_STAGING is fairly obvious,
> for things like nodejs, it's a little bit less obvious for the ones who
> are not familiar with what nodejs is.
Done.
I've submitted the updated patch as V3.
Regards,
Jonathan
prev parent reply other threads:[~2012-08-12 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 6:11 [Buildroot] [PATCH] nodejs: new package Jonathan Liu
2012-08-11 20:23 ` Thomas Petazzoni
[not found] ` <502703DF.5000602@gmail.com>
2012-08-12 7:06 ` Thomas Petazzoni
2012-08-12 8:51 ` Jonathan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50276E78.3030009@gmail.com \
--to=net147@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.