All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	seabios@seabios.org, kvm@vger.kernel.org
Subject: Re: [PATCH] tsc: use kvmclock for calibration
Date: Sun, 12 Aug 2012 12:01:57 +0300	[thread overview]
Message-ID: <50277105.8070909@redhat.com> (raw)
In-Reply-To: <20120809185900.GD20889@amt.cnet>

On 08/09/2012 09:59 PM, Marcelo Tosatti wrote:
>> 
>> > +    wrmsr(msr, 0);
>> > +    if (time.version < 2 || time.tsc_to_system_mul == 0)
>> > +        return 0;
>> > +
>> > +    /* go figure tsc frequency */
>> > +    khz = pvclock_tsc_khz(&time);
>> > +    dprintf(1, "Using kvmclock, msr 0x%x, tsc %d MHz\n",
>> > +            msr, (u32)khz / 1000);
>> > +    return khz;
>> 
>> That's a meaningless number.  You can be migrated to a cpu or a machine
>> with very different tsc.
> 
> Thats why there exists hardware tsc frequency scaling and the software
> equivalent for that on kvm.
> 

The hardware is only available on a minority of processors in the field.
 The software equivalent isn't there.

-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2012-08-12  9:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 11:57 [PATCH] tsc: use kvmclock for calibration Gerd Hoffmann
2012-08-09 12:53 ` Avi Kivity
2012-08-09 13:25   ` [SeaBIOS] " Fred .
2012-08-09 13:57   ` Gerd Hoffmann
2012-08-09 14:01     ` Avi Kivity
2012-08-09 14:05       ` Avi Kivity
2012-08-09 14:12         ` Gerd Hoffmann
2012-08-09 14:17           ` Avi Kivity
2012-08-09 14:18       ` Gerd Hoffmann
2012-08-09 14:20         ` Avi Kivity
2012-08-09 19:02           ` Marcelo Tosatti
2012-08-12 10:56             ` Avi Kivity
2012-08-09 19:09       ` Marcelo Tosatti
2012-08-10  7:18         ` Gleb Natapov
2012-08-10  7:30           ` Gleb Natapov
2012-08-10  8:10         ` Gerd Hoffmann
2012-08-10 21:26           ` Marcelo Tosatti
2012-08-13 10:37             ` Gerd Hoffmann
2012-08-13 10:46               ` Gleb Natapov
2012-08-13 12:55                 ` [SeaBIOS] " Fred .
2012-08-12  9:00           ` Avi Kivity
2012-08-09 18:59   ` Marcelo Tosatti
2012-08-12  9:01     ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50277105.8070909@redhat.com \
    --to=avi@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.