From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] dvb_frontend: return -ENOTTY for unimplement IOCTL
Date: Sun, 12 Aug 2012 12:30:50 -0300 [thread overview]
Message-ID: <5027CC2A.1060608@redhat.com> (raw)
In-Reply-To: <1344551101-16700-3-git-send-email-crope@iki.fi>
Em 09-08-2012 19:25, Antti Palosaari escreveu:
> Earlier it was returning -EOPNOTSUPP.
This change makes all sense to me. We just need to be sure that this won't
cause any regressions on userspace apps.
Regards,
Mauro
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/dvb/dvb-core/dvb_frontend.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
> index 4548fc9..4fc11eb 100644
> --- a/drivers/media/dvb/dvb-core/dvb_frontend.c
> +++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
> @@ -1830,7 +1830,7 @@ static int dvb_frontend_ioctl(struct file *file,
> struct dvb_frontend *fe = dvbdev->priv;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> struct dvb_frontend_private *fepriv = fe->frontend_priv;
> - int err = -EOPNOTSUPP;
> + int err = -ENOTTY;
>
> dev_dbg(fe->dvb->device, "%s: (%d)\n", __func__, _IOC_NR(cmd));
> if (fepriv->exit != DVB_FE_NO_EXIT)
> @@ -1948,7 +1948,7 @@ static int dvb_frontend_ioctl_properties(struct file *file,
> }
>
> } else
> - err = -EOPNOTSUPP;
> + err = -ENOTTY;
>
> out:
> kfree(tvp);
> @@ -2081,7 +2081,7 @@ static int dvb_frontend_ioctl_legacy(struct file *file,
> struct dvb_frontend *fe = dvbdev->priv;
> struct dvb_frontend_private *fepriv = fe->frontend_priv;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> - int cb_err, err = -EOPNOTSUPP;
> + int cb_err, err = -ENOTTY;
>
> if (fe->dvb->fe_ioctl_override) {
> cb_err = fe->dvb->fe_ioctl_override(fe, cmd, parg,
>
next prev parent reply other threads:[~2012-08-12 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 22:24 [PATCH RFC 0/3] dvb-frontend statistic IOCTL validation Antti Palosaari
2012-08-09 22:24 ` [PATCH RFC 1/3] dvb_frontend: use Kernel dev_* logging Antti Palosaari
2012-08-12 15:37 ` Mauro Carvalho Chehab
2012-08-09 22:25 ` [PATCH RFC 2/3] dvb_frontend: return -ENOTTY for unimplement IOCTL Antti Palosaari
2012-08-12 15:30 ` Mauro Carvalho Chehab [this message]
2012-08-09 22:25 ` [PATCH RFC 3/3] dvb_frontend: do not allow statistic IOCTLs when sleeping Antti Palosaari
2012-08-12 15:28 ` Mauro Carvalho Chehab
2012-08-12 16:28 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5027CC2A.1060608@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.