All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: "Benoît Canet" <benoit.canet@gmail.com>,
	stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	"Blue Swirl" <blauwirbel@gmail.com>,
	anthony@codemonkey.ws, pbonzini@redhat.com, eblake@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().
Date: Mon, 13 Aug 2012 09:41:00 +0200	[thread overview]
Message-ID: <5028AF8C.8090803@redhat.com> (raw)
In-Reply-To: <20120810174824.GB2033@irqsave.net>

Am 10.08.2012 19:48, schrieb Benoît Canet:
> Le Tuesday 07 Aug 2012 à 20:30:09 (+0000), Blue Swirl a écrit :
>> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet <benoit.canet@gmail.com> wrote:
>>> Signed-off-by: Benoit Canet <benoit@irqsave.net>
>>> ---
>>>  block/quorum.c |   62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 62 insertions(+)
>>>
>>> diff --git a/block/quorum.c b/block/quorum.c
>>> index e0405b6..de58ab8 100644
>>> --- a/block/quorum.c
>>> +++ b/block/quorum.c
>>> @@ -47,11 +47,73 @@ struct QuorumAIOCB {
>>>      int vote_ret;
>>>  };
>>>
>>> +/* Valid quorum filenames look like
>>> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image
>>
>> This syntax would mean that stacking for example curl or other network
>> paths would not be possible. How about comma as separator?
> 
> I just tried comma but it fail because the qemu command line parsing
> catch it believing that the string next to the coma is another "file="
> like options.
> 
> Is there any other separator we can use ?

I would ignore that for now, or you can introduce your own escaping of
colons. The real solution is, once again, -blockdev.

Kevin

  reply	other threads:[~2012-08-13  7:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 13:44 [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency Benoît Canet
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 01/10] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-07 20:24   ` Blue Swirl
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 02/10] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open() Benoît Canet
2012-08-07 20:30   ` Blue Swirl
2012-08-07 20:40     ` Eric Blake
2012-08-10 17:48     ` Benoît Canet
2012-08-13  7:41       ` Kevin Wolf [this message]
2012-08-14 16:56         ` Benoît Canet
2012-08-15 10:40           ` Kevin Wolf
2012-08-08 15:04   ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close() Benoît Canet
2012-08-07 20:30   ` Blue Swirl
2012-08-08 15:06     ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength() Benoît Canet
2012-08-08 15:30   ` Stefan Hajnoczi
2012-08-09  9:07     ` Benoît Canet
2012-08-09  9:14       ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-08-08 15:37   ` Stefan Hajnoczi
2012-08-09  9:24     ` Benoît Canet
2012-08-09  9:35       ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 07/10] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public Benoît Canet
2012-08-08 15:38   ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 08/10] quorum: Add quorum_co_flush() Benoît Canet
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 09/10] quorum: Add quorum_aio_readv Benoît Canet
2012-08-08 15:44   ` Stefan Hajnoczi
2012-08-08 15:46     ` Stefan Hajnoczi
2012-08-07 13:44 ` [Qemu-devel] [RFC V2 10/10] quorum: Add quorum mechanism Benoît Canet
2012-08-08 15:54   ` Stefan Hajnoczi
2012-08-08 14:55 ` [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency Stefan Hajnoczi
2012-08-10 17:45   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5028AF8C.8090803@redhat.com \
    --to=kwolf@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=benoit.canet@gmail.com \
    --cc=benoit.canet@irqsave.net \
    --cc=blauwirbel@gmail.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.