From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: xl segfault when starting a guest Date: Mon, 13 Aug 2012 15:55:57 +0200 Message-ID: <5029076D.2090803@amd.com> References: <501BDF23.50409@amd.com> <1344005133.21372.54.camel@zakaz.uk.xensource.com> <501BEAD8.3040300@amd.com> <1344244422.11339.17.camel@zakaz.uk.xensource.com> <20511.54333.44714.694390@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20511.54333.44714.694390@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org On 08/06/12 16:27, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] xl segfault when starting a guest"): >> It looks like 25727:a8d708fcb347 is missing some bits of my original >> patch got missed during application, specifically the changes to the >> iscsi/nbd/enbd prefix handling rule. > > This was because: > - I mistakenly used the copy of the patch that Ian C had CC'd to me, > rather than the copy I got via the mailing list. The former went > via the Citrix corporate email system which mangles things, which > is why this is a bad idea. The latter does not. > - When I tried to apply it, it produced a bunch of rejects in the > autogenerated files. However buried in those messages was a reject > in the .l source file, which I didn't spot. > - I therefore tried to regenerate the flex source (perhaps not with > complete success) and committed the result. > Sorry for messing this up. > > I have backed out 25727:a8d708fcb347 and reapplied what I think is a > non-mangled version as 25733:353bc0801b11. Works for me. Thanks. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632