All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Zhbanov <i.zhbanov at samsung.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Fix screen DPMS support detection
Date: Mon, 13 Aug 2012 20:52:28 +0400	[thread overview]
Message-ID: <502930CC.5070204@samsung.com> (raw)
In-Reply-To: 50292E9F.40009@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

Hi Arjan,

Please look at my next patch too. I try to get rid of things like:
-2147483648%, "Display backlight",

The problem is that on some architectures max_brightness is 0. And you 
can find
division by zero and getting NaNs in backlight code. So I try to fix it 
not to use incorrect
values when DPMS is disabled or backlight control is not supported.

Arjan van de Ven wrote:
> On 8/13/2012 9:41 AM, Igor Zhbanov wrote:
>> Consider DPMS disabled when we can't open /sys/class/drm/card0 directory.
> if you don't have a graphics card with proper driver...
> there's nothing we can do and pretending that DPMS is disabled sounds like a mostly bad idea
> on first sight
>
> what is behind the idea of assuming it disabled ???
>
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>


-- 
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation


             reply	other threads:[~2012-08-13 16:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 16:52 Igor Zhbanov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-14 15:34 [Powertop] [PATCH] Fix screen DPMS support detection Chris Ferron
2012-08-14  6:11 Igor Zhbanov
2012-08-13 17:35 Arjan van de Ven
2012-08-13 16:43 Arjan van de Ven
2012-08-13 16:41 Igor Zhbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502930CC.5070204@samsung.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.