All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Wang Dongsheng-B40534 <B40534@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	Li Yang-R58472 <r58472@freescale.com>,
	"paulus@samba.org" <paulus@samba.org>,
	Gala Kumar-B11780 <B11780@freescale.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
Date: Mon, 13 Aug 2012 12:36:54 -0500	[thread overview]
Message-ID: <50293B36.1000408@freescale.com> (raw)
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB14CA@039-SN2MPN1-022.039d.mgd.msft.net>

On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>> +	p = of_get_property(np, "available-ranges", &len);
>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>> +				np->full_name);
>>> +		return -EINVAL;
>>> +	}
>>
>> You need to support fsl,available-ranges since that's in an accepted
>> binding and people could have partitioned setups already using it.
>>
> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group)
> in each group only four timer. This is unified. So i use a generic name.
> I think there is not compatible with existing mpic timer nodes.

We need to be compatible with existing trees, so you'd need to check for
both -- but I think any further discussion of the details is premature
until we decide whether this is worthwhile to begin with (both the
support of non-FSL timers, and the creation of a new device tree binding
which will not be implemented by many of the machines that have non-FSL
openpic because they run real Open Firmware).

-Scott

  reply	other threads:[~2012-08-13 17:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10  5:54 [PATCH v2 2/2] powerpc/mpic: add global timer support Dongsheng.wang
2012-08-10 19:40 ` Scott Wood
2012-08-10 20:24   ` Gala Kumar-B11780
2012-08-13  5:53   ` Wang Dongsheng-B40534
2012-08-13  6:17     ` Li Yang-R58472
2012-08-13  6:17       ` Li Yang-R58472
2012-08-13 16:50       ` Scott Wood
2012-08-13 16:50         ` Scott Wood
2012-08-13 16:49     ` Scott Wood
2012-08-14  2:06       ` Wang Dongsheng-B40534
2012-08-10 20:37 ` Scott Wood
2012-08-13  6:18   ` Wang Dongsheng-B40534
2012-08-13 17:36     ` Scott Wood [this message]
2012-08-14  2:00       ` Wang Dongsheng-B40534
2012-08-14  2:05         ` Scott Wood
2012-08-14  2:15           ` Wang Dongsheng-B40534
2012-08-14  2:18             ` Scott Wood
2012-08-14  2:32               ` Wang Dongsheng-B40534
2012-08-14 21:20                 ` Scott Wood
2012-08-11 13:10 ` Tabi Timur-B04825
2012-08-13  6:20   ` Wang Dongsheng-B40534
2012-08-13  6:25     ` Wang Dongsheng-B40534

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50293B36.1000408@freescale.com \
    --to=scottwood@freescale.com \
    --cc=B07421@freescale.com \
    --cc=B11780@freescale.com \
    --cc=B40534@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=r58472@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.