From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection Date: Mon, 13 Aug 2012 20:06:17 +0200 Message-ID: <50294219.3080800@siemens.com> References: <1344846917-7411-1-git-send-email-nab@linux-iscsi.org> <1344846917-7411-2-git-send-email-nab@linux-iscsi.org> <5028EDB2.10506@siemens.com> <20120813180312.GA19379@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120813180312.GA19379@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: Anthony Liguori , Stefan Hajnoczi , kvm-devel , qemu-devel , Zhi Yong Wu , Anthony Liguori , target-devel , Paolo Bonzini , lf-virt , Christoph Hellwig List-Id: virtualization@lists.linuxfoundation.org On 2012-08-13 20:03, Michael S. Tsirkin wrote: > On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote: >> On 2012-08-13 10:35, Nicholas A. Bellinger wrote: >>> From: Nicholas Bellinger >>> >>> This is required to get past the following assert with: >>> >>> commit 1523ed9e1d46b0b54540049d491475ccac7e6421 >>> Author: Jan Kiszka >>> Date: Thu May 17 10:32:39 2012 -0300 >>> >>> virtio/vhost: Add support for KVM in-kernel MSI injection >>> >>> Cc: Stefan Hajnoczi >>> Cc: Jan Kiszka >>> Cc: Paolo Bonzini >>> Cc: Anthony Liguori >>> Signed-off-by: Nicholas Bellinger >>> --- >>> hw/msix.c | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/msix.c b/hw/msix.c >>> index 800fc32..c1e6dc3 100644 >>> --- a/hw/msix.c >>> +++ b/hw/msix.c >>> @@ -544,6 +544,9 @@ void msix_unset_vector_notifiers(PCIDevice *dev) >>> { >>> int vector; >>> >>> + if (!dev->msix_vector_use_notifier && !dev->msix_vector_release_notifier) >>> + return; >>> + >>> assert(dev->msix_vector_use_notifier && >>> dev->msix_vector_release_notifier); >>> >>> >> >> I think to remember pointing out that there is a bug somewhere in the >> reset code which deactivates a non-active vhost instance, no? >> >> Jan > > Could not find it. Could you dig it up pls? http://thread.gmane.org/gmane.linux.scsi.target.devel/2277/focus=2309 Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0z2F-0002Ag-KA for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0z2C-00067z-Qm for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:06:39 -0400 Received: from goliath.siemens.de ([192.35.17.28]:30633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0z2C-000669-Gi for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:06:36 -0400 Message-ID: <50294219.3080800@siemens.com> Date: Mon, 13 Aug 2012 20:06:17 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1344846917-7411-1-git-send-email-nab@linux-iscsi.org> <1344846917-7411-2-git-send-email-nab@linux-iscsi.org> <5028EDB2.10506@siemens.com> <20120813180312.GA19379@redhat.com> In-Reply-To: <20120813180312.GA19379@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , Stefan Hajnoczi , kvm-devel , qemu-devel , "Nicholas A. Bellinger" , Zhi Yong Wu , Anthony Liguori , target-devel , Hannes Reinecke , Paolo Bonzini , lf-virt , Christoph Hellwig On 2012-08-13 20:03, Michael S. Tsirkin wrote: > On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote: >> On 2012-08-13 10:35, Nicholas A. Bellinger wrote: >>> From: Nicholas Bellinger >>> >>> This is required to get past the following assert with: >>> >>> commit 1523ed9e1d46b0b54540049d491475ccac7e6421 >>> Author: Jan Kiszka >>> Date: Thu May 17 10:32:39 2012 -0300 >>> >>> virtio/vhost: Add support for KVM in-kernel MSI injection >>> >>> Cc: Stefan Hajnoczi >>> Cc: Jan Kiszka >>> Cc: Paolo Bonzini >>> Cc: Anthony Liguori >>> Signed-off-by: Nicholas Bellinger >>> --- >>> hw/msix.c | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/msix.c b/hw/msix.c >>> index 800fc32..c1e6dc3 100644 >>> --- a/hw/msix.c >>> +++ b/hw/msix.c >>> @@ -544,6 +544,9 @@ void msix_unset_vector_notifiers(PCIDevice *dev) >>> { >>> int vector; >>> >>> + if (!dev->msix_vector_use_notifier && !dev->msix_vector_release_notifier) >>> + return; >>> + >>> assert(dev->msix_vector_use_notifier && >>> dev->msix_vector_release_notifier); >>> >>> >> >> I think to remember pointing out that there is a bug somewhere in the >> reset code which deactivates a non-active vhost instance, no? >> >> Jan > > Could not find it. Could you dig it up pls? http://thread.gmane.org/gmane.linux.scsi.target.devel/2277/focus=2309 Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux