From: Mike Christie <michaelc@cs.wisc.edu>
To: Masatake YAMATO <yamato@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments
Date: Mon, 13 Aug 2012 13:43:53 -0500 [thread overview]
Message-ID: <50294AE9.10207@cs.wisc.edu> (raw)
In-Reply-To: <1344859172-31808-1-git-send-email-yamato@redhat.com>
On 08/13/2012 06:59 AM, Masatake YAMATO wrote:
> In iscsi_free_task, NULL is assigned to task->sc twice: before and
> after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
> with session->lock, so multiple NULL assignments cause no trouble. But
> people reading the source code may be confused.
>
> The second NULL assignment comes from commit:
>
> 3e5c28ad0391389959ccae81c938c7533efb3490
>
> It seems that the line after kfifo_in invocation was introduced
> accidentally.
>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Thanks for resending to the linux-scsi list and picking up my reviewed
by line. Looks ok to me.
next prev parent reply other threads:[~2012-08-13 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 11:59 [PATCH] libiscsi: avoid unnecessary multiple NULL assignments Masatake YAMATO
2012-08-13 18:43 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-12 14:15 Masatake YAMATO
[not found] ` <1344780951-5011-1-git-send-email-yamato-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-08-13 1:30 ` Michael Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50294AE9.10207@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-scsi@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.