From: Mike Christie <michaelc@cs.wisc.edu>
To: John Soni Jose <sony.john-n@Emulex.Com>
Cc: linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>
Subject: Re: [PATCH 2/7] Issue MBX Cmd for login to boot target in crashdump mode
Date: Mon, 13 Aug 2012 13:52:42 -0500 [thread overview]
Message-ID: <50294CFA.1060004@cs.wisc.edu> (raw)
In-Reply-To: <7012c437-3ab4-4cbb-9ecc-555d2fbf0df6@exht1.ad.emulex.com>
On 08/13/2012 05:29 AM, John Soni Jose wrote:
> When the driver comes up in crashdump mode, it has to explicitly
> issue command to FW for logging to the boot target. This fix issues
> MBX Cmd to login to boot target in crashdump mode.
>
> Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
Could you fix the whitespace/tabs so they match the rest of the driver?
> + * beiscsi_get_boot_info : Get the boot session info
Driver does "-". I think for proper docbook style for functions we are
supposed to do "() -", but just - is ok for now, until we come alone and
fix them all.
> + * @phba : the device priv structure instance.
No space after phba. Check other places.
> +unsigned int mgmt_reopen_session(struct beiscsi_hba *phba,
> + unsigned int reopen_type, unsigned int sess_handle)
Need some tabs. Check other places.
> +/**
> + * be_mgmt_get_boot_shandle : Get the session handle for
> + * boot session.
Not sure what happened with that second line.
prev parent reply other threads:[~2012-08-13 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 10:29 [PATCH 2/7] Issue MBX Cmd for login to boot target in crashdump mode John Soni Jose
2012-08-13 18:52 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50294CFA.1060004@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=sony.john-n@Emulex.Com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.