All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: John Soni Jose <sony.john-n@Emulex.Com>
Cc: linux-scsi@vger.kernel.org,
	Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>
Subject: Re: [PATCH 5/7] Add support for configuring the VLAN on the adapter.
Date: Mon, 13 Aug 2012 14:01:32 -0500	[thread overview]
Message-ID: <50294F0C.2080205@cs.wisc.edu> (raw)
In-Reply-To: <1ccc8229-524d-4778-823f-bab06ee80b10@exht1.ad.emulex.com>

On 08/13/2012 05:30 AM, John Soni Jose wrote:
>  
> +/**
> +  * beiscsi_set_vlan_attrib : Set the VLAN priority
> +  *	@shost : Scsi_Host pointer for the function.

extra space.


> +	case ISCSI_NET_PARAM_VLAN_ID:
> +		if (if_info.vlan_priority == BEISCSI_VLAN_DISABLE)
> +			len = sprintf(buf, "\n");
> +		else
> +			len = sprintf(buf, "%d\n",
> +					(if_info.vlan_priority &
> +					 ISCSI_MAX_VLAN_ID));
> +		break;
> +	case ISCSI_NET_PARAM_VLAN_PRIORITY:
> +		if (if_info.vlan_priority == BEISCSI_VLAN_DISABLE)
> +			len = sprintf(buf, "\n");

If its disabled then return -EINVAL.

      reply	other threads:[~2012-08-13 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 10:30 [PATCH 5/7] Add support for configuring the VLAN on the adapter John Soni Jose
2012-08-13 19:01 ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50294F0C.2080205@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=jayamohan.kallickal@Emulex.Com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sony.john-n@Emulex.Com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.