From: Meador Inge <meadori@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property
Date: Mon, 13 Aug 2012 15:34:27 -0500 [thread overview]
Message-ID: <502964D3.4070800@codesourcery.com> (raw)
In-Reply-To: <1344871919-31559-2-git-send-email-peter.maydell@linaro.org>
On 08/13/2012 10:31 AM, Peter Maydell wrote:
> Fix an incorrect default value for the num-irqs property (we were
> attempting to override it from the default set by the parent class
> but not succeeding, which meant that the lm3s6965evb model would
> assert on startup attempting to wire up nonexistent irq lines).
> Instead of trying to override the parent's Property array, we
> define an instance_init function which runs after default setup
> but before user property setting and can just fix up the default
> value in the gic_state struct.
>
> Reported-by: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
> Tested-by: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
I noticed this assertion recently as well while hacking on some Cortex-M3 stuff:
qemu-system-arm: /home/meadori/Code/src/qemu/hw/qdev.c:310: qdev_get_gpio_in:
Assertion `n >= 0 && n < dev->num_gpio_in' failed.
Aborted (core dumped)
I just tried out your patch and it fixes the issue I was seeing.
Tested-by: Meador Inge <meadori@codesoucery.com>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
next prev parent reply other threads:[~2012-08-13 20:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:31 [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property Peter Maydell
2012-08-13 20:34 ` Meador Inge [this message]
2012-08-13 15:31 ` [Qemu-devel] [PATCH 02/10] armv7m: Guard against no -kernel argument Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 03/10] hw/sd.c: convert wp_groups in SDState to bitfield Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 04/10] hw/sd.c: make sd_wp_addr() accept 64 bit address argument Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 05/10] hw/sd.c: introduce wrapper for conversion address to wp group Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 06/10] hw/sd.c: convert binary variables to bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 07/10] hw/sd.c: make sd_dataready() return bool Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 08/10] hw/sd.c: make sd_wp_addr() " Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 09/10] ssd0323: abort() instead of exit(1) on error Peter Maydell
2012-08-13 15:31 ` [Qemu-devel] [PATCH 10/10] arm: Move some ARM devices into libhw Peter Maydell
2012-08-14 0:12 ` [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502964D3.4070800@codesourcery.com \
--to=meadori@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.