From: "H. Peter Anvin" <hpa@zytor.com>
To: Betty Dall <betty.dall@hp.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, pci: Fix all early PCI scans to check the vendor ID first
Date: Mon, 13 Aug 2012 15:01:51 -0700 [thread overview]
Message-ID: <5029794F.1050302@zytor.com> (raw)
In-Reply-To: <1344895094.23469.37.camel@ejdallLaptop>
On 08/13/2012 02:58 PM, Betty Dall wrote:
>
> I checked the PCI specification, and Peter is right that function
> numbers can be sparse. Please go with version 1 of the patch, as Andi
> suggested. I will follow up by looking at why the three scans are not
> consistent and send a patch, if appropriate. The scans could be improved
> by stopping the function scan if function 0 does not exist because
> function 0 is required, and if it is not there then none of the other
> functions will be implemented.
>
Yes, if function 0 doesn't exist we could, and *should* skip functions
1-7; in fact, we should not process functions 1-7 unless the
multifunction bit is set in function 0. This matters on real devices in
the field.
-hpa
next prev parent reply other threads:[~2012-08-13 22:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 22:17 [PATCH] x86, pci: Fix all early PCI scans to check the vendor ID first Andi Kleen
2012-08-09 22:34 ` Betty Dall
2012-08-09 23:41 ` Andi Kleen
2012-08-10 23:57 ` H. Peter Anvin
2012-08-11 10:43 ` Andi Kleen
2012-08-13 21:58 ` Betty Dall
2012-08-13 22:01 ` H. Peter Anvin [this message]
2012-08-13 3:23 ` Khalid Aziz
2012-08-13 3:24 ` H. Peter Anvin
2012-08-13 4:15 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029794F.1050302@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=betty.dall@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.