From: Denis <yefremov.denis@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
ldv-project@ispras.ru
Subject: Re: [PATCH] [NETFILTER] bridge: rcu_deref outside read-lock section
Date: Tue, 14 Aug 2012 11:32:37 +0400 [thread overview]
Message-ID: <5029FF15.4030903@gmail.com> (raw)
In-Reply-To: <20120813163641.69a8388a@nehalam.linuxnetplumber.net>
On 14.08.2012 3:36, Stephen Hemminger wrote:
> Why not just move the rcu_read_lock() in br_dev_xmit earlier?
I don't know the semantics of this code, so it's difficult for me to
choose the appropriate place. I thought that the callers
of br_nf_pre_routing_finish_bridge_slow function are limited to
br_dev_xmit and we can modify header without problems.
Anyway, I will send another version of the patch.
next prev parent reply other threads:[~2012-08-14 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 22:47 [PATCH] bridge: rcu_deref outside read-lock section Denis Efremov
2012-08-13 22:47 ` [PATCH] [NETFILTER] " Denis Efremov
2012-08-13 23:36 ` Stephen Hemminger
2012-08-14 7:32 ` Denis [this message]
2012-08-14 8:08 ` [PATCH v2] " Denis Efremov
2012-08-14 15:19 ` [PATCH] bridge: fix rcu dereference outside of rcu_read_lock Stephen Hemminger
2012-08-15 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029FF15.4030903@gmail.com \
--to=yefremov.denis@gmail.com \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=ldv-project@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.