From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 14 Aug 2012 10:31:28 +0200 Subject: [U-Boot] [PATCH v2 3/4] mxs: rename regs-clkctrl.h to regs-clkctrl-mx28.h In-Reply-To: <1344887592-28393-3-git-send-email-otavio@ossystems.com.br> References: <1344887592-28393-1-git-send-email-otavio@ossystems.com.br> <1344887592-28393-3-git-send-email-otavio@ossystems.com.br> Message-ID: <502A0CE0.9030500@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/08/2012 21:53, Otavio Salvador wrote: > The CLKCTRL registers are SoC specific so we ought to have it clear on > filename. > > Signed-off-by: Otavio Salvador > --- > Changes in v2: > - no changes > Hi Otavio, > arch/arm/include/asm/arch-mxs/imx-regs.h | 2 +- > .../arm/include/asm/arch-mxs/{regs-clkctrl.h => regs-clkctrl-mx28.h} | 0 > drivers/usb/host/ehci-mxs.c | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > rename arch/arm/include/asm/arch-mxs/{regs-clkctrl.h => regs-clkctrl-mx28.h} (100%) > > diff --git a/arch/arm/include/asm/arch-mxs/imx-regs.h b/arch/arm/include/asm/arch-mxs/imx-regs.h > index 37d0a93..5e1901e 100644 > --- a/arch/arm/include/asm/arch-mxs/imx-regs.h > +++ b/arch/arm/include/asm/arch-mxs/imx-regs.h > @@ -26,7 +26,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/arch/arm/include/asm/arch-mxs/regs-clkctrl.h b/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h > similarity index 100% > rename from arch/arm/include/asm/arch-mxs/regs-clkctrl.h > rename to arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h > diff --git a/drivers/usb/host/ehci-mxs.c b/drivers/usb/host/ehci-mxs.c > index e263747..6e21669 100644 > --- a/drivers/usb/host/ehci-mxs.c > +++ b/drivers/usb/host/ehci-mxs.c > @@ -23,7 +23,7 @@ > #include > #include > #include > -#include > +#include > #include > #include Well, this is not clear - maybe because I do not know your plan. I suppose that general header, that is imx-regs.h, and drivers such as ehci-mxs should not include SOC specific headers, so that they can be used with both SOCs. The indirection should be done in a deeper level. Both includes currently headers referred to the specific function (gpmi, bch, base, ...), not to a specific SOC. Then I am expecting that inside regs-clkctrl.h (or another header) there are details for both SOCs, or if you want to split they completely, regs-clkctrl.h is something like regs-clkctrl.h: #ifdef MX28 include #else #ifdef MX23 include .... Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================