From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rabin Vincent <rabin@rab.in>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"lrg@ti.com" <lrg@ti.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: "regulator: Enable supply regulator if child rail is enabled" broken?
Date: Tue, 14 Aug 2012 14:21:44 +0530 [thread overview]
Message-ID: <502A11A0.7070906@nvidia.com> (raw)
In-Reply-To: <CAH+eYFAJ0FSiZoDiyYJsEg1j-cAhG7DkCwFNJGe5vBNpiUM7ug@mail.gmail.com>
On Tuesday 14 August 2012 02:08 PM, Rabin Vincent wrote:
> It appears that this patch causes incorrect reference counting on supply
> regulators if the child regulator is enabled with for example boot_on=true:
>
> commit b2296bd43e781976743354c668a356b0df98e1da
> Author: Laxman Dewangan<ldewangan@nvidia.com>
> Date: Mon Jan 2 13:08:45 2012 +0530
>
> regulator: Enable supply regulator if child rail is enabled.
>
> If a regulator is enabled at boot (by constraints), then this patch calls
> regulator_enable() on the supply regulator, leading to a use_count increase on
> the supply. However, this patch adds no code to perform the corresponding
> regulator_disable(), leaving the supply regulator on even when all consumers
> have disabled it.
>
> AFAICS, this patch would have only worked for always_on regulators.
Yaah, It is missing the regulator_disable() in regulator_init_complete()
for some cases.
Please let me know if I need to send patch for fixing this issue.
next prev parent reply other threads:[~2012-08-14 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 8:38 "regulator: Enable supply regulator if child rail is enabled" broken? Rabin Vincent
2012-08-14 8:51 ` Laxman Dewangan [this message]
2012-08-14 9:15 ` Rabin Vincent
2012-08-14 10:11 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A11A0.7070906@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.