All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martyn Welch <martyn.welch@ge.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2]staging "vme" Fix typos.
Date: Tue, 14 Aug 2012 10:14:00 +0100	[thread overview]
Message-ID: <502A16D8.5040206@ge.com> (raw)
In-Reply-To: <1344878902-22059-1-git-send-email-justinmattock@gmail.com>

On 13/08/12 18:28, Justin P. Mattock wrote:
> From: "Justin P. Mattock" <justinmattock@gmail.com>
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---
> Note:resend with minor adjustments.
> The below patch fixes typos found while reading through staging "vme"
> 
>  drivers/staging/vme/devices/vme_user.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index e25645e..0170788 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -64,13 +64,13 @@ static unsigned int bus_num;
>   *
>   * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't
>   * even support the tsi148 chipset (which has 8 master and 8 slave windows).
> - * We'll run with this or now as far as possible, however it probably makes
> + * We'll run with this for now as far as possible, however it probably makes
>   * sense to get rid of the old mappings and just do everything dynamically.
>   *
>   * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as
>   * defined above and try to support at least some of the interface from
> - * http://www.vmelinux.org/ as an alternative drive can be written providing a
> - * saner interface later.
> + * http://www.vmelinux.org/ as an alternative the driver can be written
> + * providing a saner interface later.
>   *
>   * The vmelinux.org driver never supported slave images, the devices reserved
>   * for slaves were repurposed to support all 8 master images on the UniverseII!
> @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count,
>  }
>  
>  /*
> - * We are going ot alloc a page during init per window for small transfers.
> + * We are going to alloc a page during init per window for small transfers.
>   * Small transfers will go user space -> buffer -> VME. Larger (more than a
>   * page) transfers will lock the user space buffer into memory and then
>   * transfer the data directly from the user space buffers out to VME.
> 

Thanks for updating the patch, that's much better:

Acked-by: Martyn Welch <martyn.welch@ge.com>

-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@ge.com                  | VAT:GB 927559189

      reply	other threads:[~2012-08-14  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 17:28 [PATCH v2]staging "vme" Fix typos Justin P. Mattock
2012-08-14  9:14 ` Martyn Welch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A16D8.5040206@ge.com \
    --to=martyn.welch@ge.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.