Re: Copyright issues, do not copy code and add your own copyrights

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 08/14/2012 11:10 AM, Manu Abraham wrote:
> Hi,
>
> The subject line says it.
>
> Please fix the offending Copyright header.
>
> Offending one.
> http://git.linuxtv.org/media_tree.git/blob/staging/for_v3.7:/drivers/media/dvb-frontends/stb6100_proc.h
>
> Original one.
> http://git.linuxtv.org/media_tree.git/blob/staging/for_v3.7:/drivers/media/dvb-frontends/stb6100_cfg.h

Or even better, get rid of the offending one and add a i2c_gate_ctrl parameters to the inline
functions defined in stb6100_cfg.h, as this seems a typical case of unnecessary code-duplication.

I would also like to point out that things like these are pretty much wrong:

   27         if (&fe->ops)
   28                 frontend_ops = &fe->ops;
   29         if (&frontend_ops->tuner_ops)
   30                 tuner_ops = &frontend_ops->tuner_ops;
   31         if (tuner_ops->get_state) {

The last check de-references tuner_ops, which only is non-NULL if
fe-ops and fe->ops->tuner_ops are non NULL. So either the last check
needs to be:
              if (tuner_ops && tuner_ops->get_state) {

Or we assume that fe-ops and fe->ops->tuner_ops are always non NULL
when this helper gets called and all the previous checks can be removed.

Regards,

Hans