From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: fix incorrect use of IEEE80211_NUM_BANDS
Date: Tue, 14 Aug 2012 17:11:35 +0300 [thread overview]
Message-ID: <502A5C97.8070107@qca.qualcomm.com> (raw)
In-Reply-To: <20120712091311.9751.60082.stgit@localhost6.localdomain6>
On 07/12/2012 12:13 PM, Kalle Valo wrote:
> ath6kl was incorrectly assuming that IEEE80211_NUM_BANDS will always be 2
> and used that also in the firmware WMI interface definitions. But after
> the support for 60 GHz was added to cfg80211 IEEE80211_NUM_BANDS changed to 3
> and this can cause all sort of problems, possibly even memory corruption.
> I only found this during code review and didn't notice any bugs, but I'm
> sure there are a few lurking somewhere.
>
> To fix this rename unused A_NUM_BANDS to ATH6KL_NUM_BANDS, which is
> always defined to be 2, and use that in WMI.
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Applied to ath6kl.git.
Kalle
prev parent reply other threads:[~2012-08-14 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 9:13 [PATCH] ath6kl: fix incorrect use of IEEE80211_NUM_BANDS Kalle Valo
2012-07-12 17:48 ` Pavel Roskin
2012-07-19 11:08 ` Kalle Valo
2012-07-19 21:11 ` Pavel Roskin
2012-07-20 6:18 ` Kalle Valo
2012-07-20 22:08 ` Pavel Roskin
2012-08-14 14:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A5C97.8070107@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.