All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH V2 1/2] ath6kl: Fix potential skb double free in ath6kl_wmi_sync_point()
Date: Tue, 14 Aug 2012 17:29:15 +0300	[thread overview]
Message-ID: <502A60BB.7000106@qca.qualcomm.com> (raw)
In-Reply-To: <1344919234-5012-1-git-send-email-vthiagar@qca.qualcomm.com>

On 08/14/2012 07:40 AM, Vasanthakumar Thiagarajan wrote:
> skb given to ath6kl_control_tx() is owned by ath6kl_control_tx().
> Calling function should not free the skb for error cases.
> This is found during code review.
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>

Thanks, both applied. There was a checkpatch warning about parenthesis
alignment in the first patch but I fixed it.

Kalle

  parent reply	other threads:[~2012-08-14 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14  4:40 [PATCH V2 1/2] ath6kl: Fix potential skb double free in ath6kl_wmi_sync_point() Vasanthakumar Thiagarajan
2012-08-14  4:40 ` [PATCH V2 2/2] ath6kl: Fix potential memory leak in ath6kl_tx_complete() Vasanthakumar Thiagarajan
2012-08-14 14:29 ` Kalle Valo [this message]
2012-08-16  6:21   ` [PATCH V2 1/2] ath6kl: Fix potential skb double free in ath6kl_wmi_sync_point() Vasanthakumar Thiagarajan
2012-08-16  6:32     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A60BB.7000106@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vthiagar@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.