From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1ITZ-0000FI-Vz for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:52:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1ITQ-0002g9-OW for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:52:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44579 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1ITQ-0002fl-HP for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:52:00 -0400 Message-ID: <502A660B.9010204@suse.de> Date: Tue, 14 Aug 2012 16:51:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1344954934-928-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1344954934-928-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexander Graf , qemu-devel@nongnu.org, karl-michael.schindler@web.de, patches@linaro.org Am 14.08.2012 16:35, schrieb Peter Maydell: > Both MacOS and Solaris have special case handling for the CPU > type, because the check_define probes will return i386 even if > the hardware is 64 bit and x86_64 would be preferable. Move > these checks earlier in the configure probing so that we can > do them only if the user didn't specify a CPU with --cpu. This > fixes a bug where the user's command line argument was being > ignored. >=20 > Signed-off-by: Peter Maydell > --- > The per-OS checks are broken for cross compilation, but this isn't > a change introduced by this patch -- they were broken before; I've > merely added a comment noting the fact and the workaround... Reviewed-by: Andreas F=E4rber Looks okay as far as I can see. We should probably do the __APPLE__ -> Darwin dance as a followup (ignoring the iOS, which can't JIT). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg