All of lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Chao <chaowang@redhat.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Dave Young <dyoung@redhat.com>, X86-ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Tejun Heo <tj@kernel.org>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH V2 0/5] x86: Create direct mappings for E820_RAM only
Date: Wed, 15 Aug 2012 13:51:55 +0800	[thread overview]
Message-ID: <502B38FB.6050603@redhat.com> (raw)
In-Reply-To: <20120814225416.GB32453@jshin-Toonie>

On 08/15/2012 06:54 AM, Jacob Shin wrote:
> On Tue, Aug 14, 2012 at 04:34:39PM +0800, Dave Young wrote:
>> On 08/14/2012 05:46 AM, Jacob Shin wrote:
>>
>>> Currently kernel direct mappings are created for all pfns between
>>> [ 0 to max_low_pfn ) and [ 4GB to max_pfn ). When we introduce memory
>>> holes, we end up mapping memory ranges that are not backed by physical
>>> DRAM. This is fine for lower memory addresses which can be marked as UC
>>> by fixed/variable range MTRRs, however we run in to trouble with high
>>> addresses.
>>>
>>> The following patchset creates direct mappings only for E820_RAM regions
>>> between 0 ~ max_low_pfn and 4GB ~ max_pfn. And leaves non-E820_RAM and
>>> memory holes unmapped.
>>
>>
>> Hi,
>>
>> Chaowang did some kdump test in a kvm guest with this patchset, 2nd
>> kenrel just reboot after some ACPI printk, see below dmesg of 2nd kernel:
>
> Hello, thanks for testing, since I have not tested under KVM .. I also have
> not tested passing in user supplied memory maps as your kernel log suggests.
>
> Looking into this, it seems like we get a page fault while trying to set up
> fixmap for the APIC. I think the fixmap is set up even before we get to
> setup_arch(), and it is sitting in memory that is not marked as usable by
> your user supplied e820.
>
> Could you give V3 a try? I just sent it out a minute ago, this version
> won't try to remap what has already been mapped as part of the boot process
> before we get to setup_arch, it'll just take what its given.
>

Hi, Jacob

I just tried v3 patchset in my x86_64 kvm guest, it was booting 
successfully and the issue mentioned is gone.

-WANG Chao


      reply	other threads:[~2012-08-15  5:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 21:46 [PATCH V2 0/5] x86: Create direct mappings for E820_RAM only Jacob Shin
2012-08-13 21:47 ` [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM Jacob Shin
2012-08-13 21:58   ` Tejun Heo
2012-08-13 22:00     ` H. Peter Anvin
2012-08-13 21:47 ` [PATCH 2/5] x86: find_early_table_space based on memory ranges that are being mapped Jacob Shin
2012-08-13 21:47 ` [PATCH 3/5] x86: Keep track of direct mapped pfn ranges Jacob Shin
2012-08-13 22:09   ` Tejun Heo
2012-08-13 21:47 ` [PATCH 4/5] x86: Fixup code testing if a pfn is direct mapped Jacob Shin
2012-08-13 21:47 ` [PATCH 5/5] x86: Move enabling of PSE and PGE out of init_memory_mapping Jacob Shin
2012-08-13 23:02   ` Tejun Heo
2012-08-14  8:34 ` [PATCH V2 0/5] x86: Create direct mappings for E820_RAM only Dave Young
2012-08-14  9:06   ` Dave Young
2012-08-14 22:54   ` Jacob Shin
2012-08-15  5:51     ` WANG Chao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502B38FB.6050603@redhat.com \
    --to=chaowang@redhat.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jacob.shin@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.