Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on sPAPR platform.

[Li Zhang <zhlcindy@linux.vnet.ibm.com>]

On 2012年08月15日 02:09, Alexander Graf wrote:
>
> On 14.08.2012, at 19:49, Li Zhang <zhlcindy@gmail.com> wrote:
>
>> USB is enabled as default on sPAPR platform because it needs
>> USB keyboard and USB mouse when VGA is enabled.
>>
>> This patch is to add USB controller on sPAPR platform.
>>
>> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> This looks a lot better than the first version :).
Thanks. :)
>
> Alex
>
>> ---
>> hw/spapr.c |    5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/spapr.c b/hw/spapr.c
>> index 81c9343..b45401b 100644
>> --- a/hw/spapr.c
>> +++ b/hw/spapr.c
>> @@ -710,6 +710,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>>          spapr_vscsi_create(spapr->vio_bus);
>>      }
>>
>> +    if (usb_enabled(true)) {
Would you help replace "true" as "spapr->has_graphics" as your patch?
We think it should be better to set the default as true when 
spapr->has_graphics.
How do you think?
>> +        pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus,
>> +                          -1, "pci-ohci");
>> +    }
>> +
>>      if (rma_size < (MIN_RMA_SLOF << 20)) {
>>          fprintf(stderr, "qemu: pSeries SLOF firmware requires >= "
>>                  "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF);
>> -- 
>> 1.7.7.6
>>


-- 

Li Zhang
IBM China Linux Technology Centre