From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1fdq-0006io-55
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1fdp-0001EV-6e
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:36:18 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:57411)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1T1fdo-0001EO-W6
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:36:17 -0400
Message-ID: <502B3CBD.9060709@weilnetz.de>
Date: Wed, 15 Aug 2012 08:07:57 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com>
	<20120813141658.1bc8b15e@doriath.home>
In-Reply-To: <20120813141658.1bc8b15e@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need
 (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Eric Blake <eblake@redhat.com>

Am 13.08.2012 19:16, schrieb Luiz Capitulino:
> On Fri, 10 Aug 2012 11:04:08 -0500
> Anthony Liguori <aliguori@us.ibm.com> wrote:
>
>> This series implements the necessary commands to implements danpb's idea to
>> remove -help parsing in libvirt.  We would introduce all of these commands in
>> 1.2 and then change the -help output starting in 1.3.
>
> Applied to the qmp branch, thanks.
>


The series breaks cross compilation of QEMU for w32 on Debian Linux:

   LINK  arm-softmmu/qemu-system-armw.exe
../qmp-marshal.o: In function `qmp_marshal_input_query_cpu_definitions':
/home/stefan/w32/qmp-marshal.c:2585: undefined reference to 
`_qmp_query_cpu_definitions'

Weak symbols obviously use a different name mangling, therefore 
qmp_query_cpu_definitions
is not found by the linker.

Adding GCC_WEAK to the declaration of qmp_query_cpu_definitions in 
generated file
qmp-commands.h fixes that.

Regards,

Stefan Weil