From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
Date: Wed, 15 Aug 2012 10:23:23 +0200 [thread overview]
Message-ID: <502B5C7B.4020502@redhat.com> (raw)
In-Reply-To: <1344522080-28833-1-git-send-email-alevy@redhat.com>
On 08/09/12 16:21, Alon Levy wrote:
> Revision bumped to 4 for new IO support, enabled for spice-server >=
> 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
> 0.12.0.
Patch doesn't apply cleanly to master.
> + if $pkg_config --atleast-version=0.12.0 spice-protocol >/dev/null 2>&1; then
> + QEMU_CFLAGS="$QEMU_CFLAGS -DQXL_HAS_IO_MONITORS_CONFIG_ASYNC"
> + fi
/me thinks now with spice-server having no dependency any more on
spice-protocol we should add a #define SPICE_PROTOCOL_VERSION to
spice-protocol so we don't need constructs like this.
Or maybe just use
#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC $whatever
#endif
?
> +#if SPICE_SERVER_VERSION >= 0x000b01 /* 0.11.1 */
> +#ifdef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
Can be on a single line:
#if (SPICE_SERVER_VERSION >= 0x000b01) &&
defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC)
Or:
#if (SPICE_SERVER_VERSION >= 0x000b01) && (SPICE_PROTOCOL_VERSION >= ...)
cheers,
Gerd
next prev parent reply other threads:[~2012-08-15 8:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:08 [Qemu-devel] [PATCH 1/2] qxl: disallow unknown revisions Alon Levy
2012-07-23 13:08 ` [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-07-23 16:33 ` [Qemu-devel] [PATCH v2] " Alon Levy
2012-07-25 9:00 ` Yonit Halperin
2012-07-25 17:29 ` Alon Levy
2012-07-26 5:26 ` Yonit Halperin
2012-07-28 8:56 ` Alon Levy
2012-07-28 9:01 ` Blue Swirl
2012-07-28 10:20 ` Alon Levy
2012-07-28 10:23 ` [Qemu-devel] [PATCH v3] " Alon Levy
2012-08-06 7:31 ` Gerd Hoffmann
2012-08-09 13:41 ` Alon Levy
2012-08-09 13:50 ` Gerd Hoffmann
2012-08-09 14:18 ` Alon Levy
2012-08-09 14:21 ` [Qemu-devel] [PATCH v4 1/2] " Alon Levy
2012-08-09 14:21 ` [Qemu-devel] [PATCH v4 2/2] configure: print spice-protocol and spice-server versions Alon Levy
2012-08-15 8:23 ` Gerd Hoffmann [this message]
2012-08-15 10:32 ` [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-08-15 10:43 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502B5C7B.4020502@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.