From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T1fFu-0008WA-Rp
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:11:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T1fFt-0002K1-O7
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:11:34 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55282 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T1fFt-0002Jw-H5
	for qemu-devel@nongnu.org; Wed, 15 Aug 2012 11:11:33 -0400
Message-ID: <502BBC22.9030205@suse.de>
Date: Wed, 15 Aug 2012 17:11:30 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1344618044-18704-1-git-send-email-aliguori@us.ibm.com>
	<1344618044-18704-2-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1344618044-18704-2-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be
 used in cpu.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>

Am 10.08.2012 19:00, schrieb Anthony Liguori:
> Header file dependency is a frickin' nightmare right now.  cpu.h tends =
to get
> included in our 'include everything' header files but qdev also needs t=
o include
> those headers mainly for qdev-properties since it knows about CharDrive=
rState
> and friends.
>=20
> We can solve this for now by splitting out qdev.h along the same lines =
that we
> previously split the C file.  Then cpu.h just needs to include qdev-cor=
e.h
>=20
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Quickly looked through and qdev.h split looks fine.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg