Re: [PATCH] OMAPDSS: Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays

["Raphaël Assénat" <raph@8d.com>]

Hi,

On 15/08/12 05:31 AM, Tomi Valkeinen wrote:
> Hi,
> 
> On Tue, 2012-07-17 at 10:01 -0400, Raphael Assenat wrote:
>> Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays.
>>
> 
> This needed to be converted to work with latest kernel. See patch below.
> I've applied the patch to my dev branch, mail me if it's not correct.
> 
> 
> commit f4e491f283266b53a926eb3c9017505b04786b9b (HEAD, dev)
> Author: Raphael Assenat <raph@8d.com>
> Date:   Tue Jul 17 10:01:40 2012 -0400
> 
>     OMAPDSS: Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays
>     
>     Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays.
>     
>     Signed-off-by: Raphael Assenat <raph@8d.com>
>     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
> index bc5af25..ae862bb 100644
> --- a/drivers/video/omap2/displays/panel-generic-dpi.c
> +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
> @@ -538,6 +538,82 @@ static struct panel_config generic_dpi_panels[] = {
>  		},
>  		.name			= "primeview_pd104slf",
>  	},
> +
> +	/* ChiMei G121S1-L01 */
> +	{
> +		{

...

> +			.vsync_level	= OMAPDSS_SIG_ACTIVE_HIGH,
> +			.hsync_level	= OMAPDSS_SIG_ACTIVE_HIGH,
> +			.data_pclk_edge	= OMAPDSS_DRIVE_SIG_RISING_EDGE,
> +			.de_level	= OMAPDSS_SIG_ACTIVE_HIGH,
> +			.sync_pclk_edge	= OMAPDSS_DRIVE_SIG_OPPOSITE_EDGES,

Actually those 3 panels only use the DE signal. The hsync/vsync signals
are not used and on our system we mux them out to make sure they are
kept low as recommended in the panel datasheets.

Since vsync/hsync are not used, I think the vsync_level, hsync_level and
sync_pclk_edge entries could be removed. Otherwise the updated patch
works fine as is.

Best regards,
Raphaël Assénat
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html