From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [v2 1/1] iommu/tegra: smmu: Use debugfs_create_dir for directory Date: Wed, 15 Aug 2012 10:13:18 -0600 Message-ID: <502BCA9E.5090206@wwwdotorg.org> References: <20120809155624.b781edae9efa7c51faf6c31c@nvidia.com> <1345009652-13408-1-git-send-email-hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345009652-13408-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Hiroshi Doyu , joerg.roedel-5C7GfCeVMHo@public.gmane.org Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 08/14/2012 11:47 PM, Hiroshi Doyu wrote: > The commit c3b1a35 "debugfs: make sure that debugfs_create_file() gets > used only for regulars" doesn't allow to use debugfs_create_file() for > dir. Keep debugfs data in smmu_device instead of directory's i_private. > > Signed-off-by: Hiroshi Doyu Tested-by: Stephen Warren Since this fixes a BUG during kernel boot, it'd be great if this could be applied ASAP unless there are significant issues with it.