From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1gIZ-0008M3-II for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:18:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1gIW-0005DX-VF for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:18:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1gIW-0005DN-N7 for qemu-devel@nongnu.org; Wed, 15 Aug 2012 12:18:20 -0400 Message-ID: <502BCBB2.4030301@redhat.com> Date: Wed, 15 Aug 2012 10:17:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345042466-31743-1-git-send-email-benoit@irqsave.net> <1345042466-31743-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1345042466-31743-3-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2333E03E7C1828841EBAC236" Subject: Re: [Qemu-devel] [PATCH 2/3] qapi: Add ImageInfo. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: aliguori@us.ibm.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2333E03E7C1828841EBAC236 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/15/2012 08:54 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 8d4df19..488da90 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -150,6 +150,39 @@ > 'vm-clock-sec': 'int' } } > =20 > ## > +# @ImageInfo: > +# > +# Information about a QEMU image file > +# > +# @filename: name of the image file > +# > +# @format: format of the image file > +# > +# @dirty-flag: true if image is not cleanly closed > +# > +# @cluster-size: size of a cluster in bytes > +# > +# @encrypted: true if the image is encrypted > +# > +# @actual-size: actual size on disk in bytes of the image > +# > +# @virtual-size: maximum capacity in bytes of the image > +# > +# @backing-filename: name of the backing file Should this be #optional, in the case where there is no backing file? Missing @backing-filename-format, when that is recorded (as long as we're going for machine-parseable, print everything useful, even if qemu-img info doesn't print it right now). Definitely #optional, since it won't be present when @backing-filename is missing, and even when a backing file name is present, the format might not have been recorded. > +# > +# @snapshots: list of VM snapshots Should this be #optional, in the case where there are no snapshots? > +# > +# Since: 1.3 So no way it will make 1.2 hard freeze today :) --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2333E03E7C1828841EBAC236 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQK8uyAAoJEKeha0olJ0NqbyIH/idSkEnY0cigZQBamxsy+zQF UEazb/6hz9Y0p8ksQZ1/6alXMluVK+DymFHUDHqUkRRKUOu5N86VEqRubg0KNzK6 cSsJj/NblKcpIJ1CgcijhUlP8pix5Bn3nGRveRwtCvTWaL3KBkigGOUeESMrEP5r as8/mjXURhxlKV8PL6YqTefeWOhnkzuxp/H/V/H0jiXagxvogmuseN7ifxPgHe4J HVhm5IzewOhMs7rY/0C7KwD9geTGLAG+v+sZsu1izzNNxZzHEzs51FZ/otBasFTr zgLWMuIjMAw2O8aKX7l2YQiX3NRlWSOq/z8zhdXeh4VbflLUY3+956nny1wrwmg= =sMI1 -----END PGP SIGNATURE----- --------------enig2333E03E7C1828841EBAC236--