From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong.
Date: Wed, 15 Aug 2012 12:13:31 -0500 [thread overview]
Message-ID: <502BD8BB.3090709@freescale.com> (raw)
In-Reply-To: <OFFB5BA265.FF7F9058-ONC1257A5B.0027026B-C1257A5B.002772AA@transmode.se>
On 08/15/2012 02:10 AM, Joakim Tjernlund wrote:
> Kumar Gala <galak@kernel.crashing.org> wrote on 2012/08/14 23:28:45:
>>
>>
>> On Jul 23, 2012, at 3:58 PM, Joakim Tjernlund wrote:
>>
>>> PowerPC mandates SP to be 16 bytes aligned.
>>> Furthermore, a stack frame is added, pointing to the reset vector
>>> which may in the way when gdb is walking the stack because
>>> the reset vector may not accessible depending on emulator settings.
>>> Also use a temp register so gdb doesn't pick up intermediate values.
>>>
>>> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>>> ---
>>>
>>> v2 - Address Scott Wood's comments
>>> arch/powerpc/cpu/mpc85xx/start.S | 16 +++++-----------
>>> 1 files changed, 5 insertions(+), 11 deletions(-)
>>
>> Acked-by: Kumar Gala <galak@kernel.crashing.org>
>
> Thanks Kumar
>
> Will you pick up?
> [PATCHv2 2/2] powerpc: Stack Pointer not properly aligned
>
> It is not 85xx specific but for all PowerPC
I don't think Kumar has a U-Boot tree to pull it into. There's no
general PPC custodian. Probably both patches should go via Andy.
-Scott
next prev parent reply other threads:[~2012-08-15 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 20:58 [U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong Joakim Tjernlund
2012-07-23 20:58 ` [U-Boot] [PATCHv2 2/2] powerpc: Stack Pointer not properly aligned Joakim Tjernlund
2012-08-14 20:55 ` Joakim Tjernlund
2012-08-14 20:55 ` [U-Boot] [PATCHv2 1/2] mpc85xx: Initial SP alignment is wrong Joakim Tjernlund
2012-08-14 21:01 ` Scott Wood
2012-08-15 7:05 ` Joakim Tjernlund
2012-08-14 21:28 ` Kumar Gala
2012-08-15 7:10 ` Joakim Tjernlund
2012-08-15 17:13 ` Scott Wood [this message]
2012-08-16 23:40 ` Andy Fleming
2012-08-22 21:08 ` Andy Fleming
2012-08-23 7:21 ` Joakim Tjernlund
2012-08-23 16:53 ` Scott Wood
2012-08-23 18:51 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BD8BB.3090709@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.