All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <esandeen@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] jbd2: don't write superblock when unmounting an ro filesystem
Date: Wed, 15 Aug 2012 12:25:15 -0500	[thread overview]
Message-ID: <502BDB7B.6030404@redhat.com> (raw)
In-Reply-To: <20120815121403.GA29223@quack.suse.cz>

On 8/15/12 7:14 AM, Jan Kara wrote:
> On Tue 24-07-12 17:05:28, Eric Sandeen wrote:
>> This sequence:
>>
>> # truncate --size=65536 fsfile
>> # losetup --offset 65536 /dev/loop0 fsfile
>> # mkfs.ext4 /dev/loop0
>> # losetup -d /dev/loop0
>> # mount -o loop,ro,offset=65536 fsfile  mnt/
>> # umount mnt
>> # dmesg | tail
>>
>> results in an IO error when unmounting the RO filesystem:
>>
>> [  312.386074] SELinux: initialized (dev loop1, type ext4), uses xattr
>> [  318.020828] Buffer I/O error on device loop1, logical block 196608
>> [  318.027024] lost page write due to I/O error on loop1
>> [  318.032088] JBD2: Error -5 detected when updating journal superblock for loop1-8.
>    Ted, did this patch fall through cracks? I've ported the fix to JBD and
> added it to my tree. I plan to send it to Linus in a few days. Also I've
> CC'd stable since this is a bit annoying regression.
>
> 								Honza


Thanks for doing both of those things, Jan.

BTW this happens on loop because mount -o,ro apparently sets up the loop 
device itself as readonly.

-Eric

  reply	other threads:[~2012-08-15 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24 22:05 [PATCH] jbd2: don't write superblock when unmounting an ro filesystem Eric Sandeen
2012-07-24 22:18 ` Eric Sandeen
2012-07-26  9:24 ` Lukáš Czerner
2012-07-30 15:49   ` Eric Sandeen
2012-08-15 12:14 ` Jan Kara
2012-08-15 17:25   ` Eric Sandeen [this message]
2012-08-18 18:45 ` Theodore Ts'o
2012-08-19 18:54   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BDB7B.6030404@redhat.com \
    --to=esandeen@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.