All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
	qemu-devel@nongnu.org, pbonzini@redhat.com,
	xiawenc@linux.vnet.ibm.com, "Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.
Date: Wed, 15 Aug 2012 12:04:56 -0600	[thread overview]
Message-ID: <502BE4C8.7060601@redhat.com> (raw)
In-Reply-To: <1345042466-31743-2-git-send-email-benoit@irqsave.net>

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On 08/15/2012 08:54 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  qapi-schema.json |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a92adb1..8d4df19 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -126,6 +126,30 @@
>              'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
>  
>  ##
> +# @SnapshotInfo
> +#
> +# @id: unique snapshot id
> +#
> +# @name: user choosen name
> +#
> +# @vm-state-size: size of the VM state
> +#
> +# @date-sec: UTC date of the snapshot
> +#
> +# @date-nsec: date in nano seconds

How come we track a subsecond creation time,

> +#
> +# @vm-clock-sec: VM clock relative to boot

but not a subsecond relative time for the VM clock?  Is that additional
precision available for querying?

I have no problem if you want to squash patches 1 and 2 together into a
single commit.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

  parent reply	other threads:[~2012-08-15 18:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 14:54 [Qemu-devel] [PATCH 0/3] Add JSON output to qemu-img info Benoît Canet
2012-08-15 14:54 ` [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo Benoît Canet
2012-08-15 17:58   ` Luiz Capitulino
2012-08-15 18:18     ` Benoît Canet
2012-08-15 18:04   ` Eric Blake [this message]
2012-08-15 18:14     ` Benoît Canet
2012-08-15 14:54 ` [Qemu-devel] [PATCH 2/3] qapi: Add ImageInfo Benoît Canet
2012-08-15 16:17   ` Eric Blake
2012-08-15 16:49     ` Benoît Canet
2012-08-15 17:47     ` Eric Blake
2012-08-15 14:54 ` [Qemu-devel] [PATCH 3/3] qemu-img: Add json output option to the info command Benoît Canet
2012-08-15 16:23   ` Eric Blake
2012-08-15 16:39     ` Benoît Canet
2012-08-15 18:16   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BE4C8.7060601@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=benoit.canet@gmail.com \
    --cc=benoit@irqsave.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.