From: Jiri Slaby <jslaby@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, dirk.brandewie@gmail.com,
khali@linux-fr.org, linux-i2c@vger.kernel.org,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, jbaron@redhat.com,
ben-linux@fluff.org, Jiri Slaby <jirislaby@gmail.com>
Subject: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1]
Date: Wed, 15 Aug 2012 22:01:38 +0200 [thread overview]
Message-ID: <502C0022.2020106@suse.cz> (raw)
In-Reply-To: <1344072256-13170-1-git-send-email-geert@linux-m68k.org>
On 08/04/2012 11:24 AM, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v3.6-rc1[1] compared to v3.5[2].
...
> + drivers/i2c/busses/i2c-designware-core.c: error: 'KBUILD_MODNAME' undeclared (first use in this function):
This is a real problem we are facing here. It happens on PPC when all
I2C_DESIGNWARE_PLATFORM, I2C_DESIGNWARE_PCI and DYNAMIC_DEBUG are set.
It's because i2c-designware-core.c is used in two modules
(i2c-designware-platform and i2c-designware-pci) and KBUILD_MODNAME is
not defined for those because (scripts/Makefile.lib):
# $(modname_flags) #defines KBUILD_MODNAME as the name of the module
# it will end up in (or would, if it gets compiled in)
# Note: Files that end up in two or more modules are compiled
# without the KBUILD_MODNAME definition. The reason is
# that any made-up name would differ in different configs.
But DYNAMIC_DEBUG needs KBUILD_MODNAME for dev_dbg used in that source.
Any ideas? Why is it not a separate module for example?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-08-15 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 9:24 Build regressions/improvements in v3.6-rc1 Geert Uytterhoeven
2012-08-15 20:01 ` Jiri Slaby [this message]
2012-08-31 12:44 ` i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1] Jean Delvare
[not found] ` <20120831144429.554345d0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-08-31 13:18 ` Jiri Slaby
2012-08-31 13:18 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502C0022.2020106@suse.cz \
--to=jslaby@suse.cz \
--cc=ben-linux@fluff.org \
--cc=dirk.brandewie@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jbaron@redhat.com \
--cc=jirislaby@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.