Re: [Qemu-devel] [PATCH 17/18] hmp: allow "bool" parameter to be optional

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

On 08/15/2012 01:41 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  monitor.c | 3 +++
>  1 file changed, 3 insertions(+)

NACK.  See patch 18 why I think you don't need this.

> 
> diff --git a/monitor.c b/monitor.c
> index db9a8d0..a538e6a 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3769,6 +3769,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>                      val = 1;
>                  } else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
>                      val = 0;
> +                } else if (*typestr == '?') {
> +                    typestr++;
> +                    break;
>                  } else {
>                      monitor_printf(mon, "Expected 'on' or 'off'\n");
>                      goto fail;
> 

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]