From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] telit: pass vendor at sim atom creation
Date: Thu, 16 Aug 2012 01:18:02 -0500 [thread overview]
Message-ID: <502C909A.9010409@gmail.com> (raw)
In-Reply-To: <1345107708-24484-1-git-send-email-christopher.vogl@hale.at>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
Hi Christopher,
On 08/16/2012 04:01 AM, Christopher Vogl wrote:
> ---
> plugins/telit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Patch has been applied, however...
> diff --git a/plugins/telit.c b/plugins/telit.c
> index 6ae7249..08ce4ad 100644
> --- a/plugins/telit.c
> +++ b/plugins/telit.c
> @@ -552,7 +552,7 @@ static void telit_pre_sim(struct ofono_modem *modem)
> DBG("%p", modem);
>
> ofono_devinfo_create(modem, 0, "atmodem", data->chat);
> - data->sim = ofono_sim_create(modem, 0, "atmodem", data->chat);
> + data->sim = ofono_sim_create(modem, OFONO_VENDOR_TELIT, "atmodem", data->chat);
Please be mindful of the 80 character per line limit. I amended the
patch for you, just this time... ;)
> ofono_voicecall_create(modem, 0, "atmodem", data->chat);
> }
>
Regards,
-Denis
prev parent reply other threads:[~2012-08-16 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 9:01 [PATCH] telit: pass vendor at sim atom creation Christopher Vogl
2012-08-16 6:18 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502C909A.9010409@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.