From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============6786715179389978874=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH] gprs: skip CGAUTO for telit
Date: Thu, 16 Aug 2012 01:24:31 -0500
Message-ID: <502C921F.803@gmail.com>
In-Reply-To: <1345109629-29468-1-git-send-email-christopher.vogl@hale.at>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============6786715179389978874==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Christopher,

On 08/16/2012 04:33 AM, Christopher Vogl wrote:
> Telit does not support +CGAUTO and will just return an error.
> To not confuse people reading the debug output, don't send the command
> for telit.
> ---
>   drivers/atmodem/gprs.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 65a8b7b..4e0823c 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -342,7 +342,11 @@ retry:
>   		goto error;
>
>   	g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
> -	g_at_chat_send(gd->chat, "AT+CGAUTO=3D0", none_prefix, NULL, NULL, NULL=
);
> +
> +	if (gd->vendor =3D=3D OFONO_VENDOR_TELIT)
> +		DBG("Telit does not support +CGAUTO command.");
> +	else
> +		g_at_chat_send(gd->chat, "AT+CGAUTO=3D0", none_prefix, NULL, NULL, NUL=
L);

What are you gaining by printing the above message and not sending the =

CGAUTO?

>
>   	switch (gd->vendor) {
>   	case OFONO_VENDOR_MBM:

Regards,
-Denis

--===============6786715179389978874==--